Re: [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support

2021-09-10 Thread Maxime Coquelin
On 9/10/21 2:58 PM, Andrew Rybchenko wrote: > On 9/10/21 2:44 PM, Maxime Coquelin wrote: >> Thanks for the review! >> >> On 9/10/21 12:06 PM, Andrew Rybchenko wrote: >>> On 9/10/21 12:17 PM, Maxime Coquelin wrote: >>> I've failed to find F_RSS definion in virtio spec. >>> Could you share th

Re: [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support

2021-09-10 Thread Andrew Rybchenko
On 9/10/21 2:44 PM, Maxime Coquelin wrote: > Thanks for the review! > > On 9/10/21 12:06 PM, Andrew Rybchenko wrote: >> On 9/10/21 12:17 PM, Maxime Coquelin wrote: >>> >> I've failed to find F_RSS definion in virtio spec. >> Could you share the reference, please. >> >> Without the sepc it is almos

Re: [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support

2021-09-10 Thread Maxime Coquelin
Thanks for the review! On 9/10/21 12:06 PM, Andrew Rybchenko wrote: > On 9/10/21 12:17 PM, Maxime Coquelin wrote: >> This patch adds RSS support to the Virtio PMD. It provides > > I'd drop the first sentence since summary already says so and > suggest to start the second from "Provide ..." > >>

Re: [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support

2021-09-10 Thread Andrew Rybchenko
On 9/10/21 12:17 PM, Maxime Coquelin wrote: > This patch adds RSS support to the Virtio PMD. It provides I'd drop the first sentence since summary already says so and suggest to start the second from "Provide ..." > the capability to update the hash key, hash types and reta reta -> RETA (see dev

[dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support

2021-09-10 Thread Maxime Coquelin
This patch adds RSS support to the Virtio PMD. It provides the capability to update the hash key, hash types and reta table on the fly (without needing to stop/start the device). However, the key length and the number of reta entries are fixed to 40B and 128 entries respectively. This is done in or