Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-18 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Ying A > Sent: Thursday, July 18, 2019 10:52 AM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check > > > > > -Original Message- > > From: Yang, Qiming > > Se

Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Wang, Ying A
> -Original Message- > From: Yang, Qiming > Sent: Thursday, July 18, 2019 10:47 AM > To: Wang, Ying A ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check > > So I think the bug is the skipped pattern don't pass to the next f

Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Yang, Qiming
So I think the bug is the skipped pattern don't pass to the next function. -Original Message- From: Wang, Ying A Sent: Thursday, July 18, 2019 10:40 AM To: Yang, Qiming ; Zhang, Qi Z Cc: dev@dpdk.org; sta...@dpdk.org Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check >

Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Wang, Ying A
> -Original Message- > From: Yang, Qiming > Sent: Thursday, July 18, 2019 10:33 AM > To: Wang, Ying A ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check > > It's no need to add RTE_FLOW_ITEM_TYPE_VOID because we have skippe

Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Yang, Qiming
It's no need to add RTE_FLOW_ITEM_TYPE_VOID because we have skipped all the VOID items. -Original Message- From: Wang, Ying A Sent: Thursday, July 18, 2019 9:39 AM To: Zhang, Qi Z Cc: Yang, Qiming ; dev@dpdk.org; Wang, Ying A ; sta...@dpdk.org Subject: [PATCH 1/3] net/ice: fix flow get

[dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check

2019-07-17 Thread Wang Ying A
ice_get_flow_field should not set error if item->type is RTE_FLOW_ITEM_TYPE_VOID. This patch fixes this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_generic_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1