Re: [dpdk-dev] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-11 Thread Olivier MATZ
Hi Yuanhan, Thanks for the fix. On Wed, 11 Jan 2017 08:59:28 +0100, Maxime Coquelin wrote: > On 01/11/2017 05:27 AM, Yuanhan Liu wrote: > > TSO is now enabled, but it's not actually being used by default in a > > simple L2 forward mode. In such case, we have to zero the virtio net > > headers, t

Re: [dpdk-dev] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-11 Thread Yuanhan Liu
On Wed, Jan 11, 2017 at 08:59:28AM +0100, Maxime Coquelin wrote: > >+/* avoid write operation when necessary, to lessen cache issues */ > >+#define ASSIGN_UNLESS_EQUAL(var, val) do { \ > >+if ((var) != (val)) \ > >+(var) = (val); \ > >+} while (

Re: [dpdk-dev] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-11 Thread Maxime Coquelin
On 01/11/2017 05:27 AM, Yuanhan Liu wrote: TSO is now enabled, but it's not actually being used by default in a simple L2 forward mode. In such case, we have to zero the virtio net headers, to inform the vhost backend that no offload is being used: hdr->csum_start = 0; hdr->csum_offset

[dpdk-dev] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-10 Thread Yuanhan Liu
TSO is now enabled, but it's not actually being used by default in a simple L2 forward mode. In such case, we have to zero the virtio net headers, to inform the vhost backend that no offload is being used: hdr->csum_start = 0; hdr->csum_offset = 0; hdr->flags = 0; hdr->gso_type =