Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions

2021-07-02 Thread Andrew Rybchenko
On 7/1/21 10:19 PM, Wiles, Keith wrote: > > >> On Jul 1, 2021, at 12:18 PM, Stephen Hemminger >> wrote: >> >> On Thu, 1 Jul 2021 17:16:21 +0300 >> Andrew Rybchenko wrote: >> >>> On 6/16/21 7:15 AM, Stephen Hemminger wrote: Since these always return 0, they were doing nothing useful.

Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions

2021-07-01 Thread Wiles, Keith
> On Jul 1, 2021, at 12:18 PM, Stephen Hemminger > wrote: > > On Thu, 1 Jul 2021 17:16:21 +0300 > Andrew Rybchenko wrote: > >> On 6/16/21 7:15 AM, Stephen Hemminger wrote: >>> Since these always return 0, they were doing nothing useful. >>> >>> Signed-off-by: Stephen Hemminger >> >> I h

Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions

2021-07-01 Thread Stephen Hemminger
On Thu, 1 Jul 2021 17:16:21 +0300 Andrew Rybchenko wrote: > On 6/16/21 7:15 AM, Stephen Hemminger wrote: > > Since these always return 0, they were doing nothing useful. > > > > Signed-off-by: Stephen Hemminger > > I have no strong opinion on the patch, but sometimes even > empty functions w

Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions

2021-07-01 Thread Andrew Rybchenko
On 6/16/21 7:15 AM, Stephen Hemminger wrote: > Since these always return 0, they were doing nothing useful. > > Signed-off-by: Stephen Hemminger I have no strong opinion on the patch, but sometimes even empty functions with comments add value. So, I see no point to touch it. So, I'll wait for ma

[dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions

2021-06-15 Thread Stephen Hemminger
Since these always return 0, they were doing nothing useful. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 573598