Re: [dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-10-24 Thread Pascal Mazon
On 25/10/2017 03:24, Ferruh Yigit wrote: > On 9/19/2017 5:45 AM, Pascal Mazon wrote: >> Hi, >> >> The patch looks mainly ok to me. >> >> I'll put some comments inline. >> >> On 18/09/2017 20:47, Ferruh Yigit wrote: >>> From: Vipin Varghese >>> >>> tap speed argument is not working without generati

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-10-24 Thread Ferruh Yigit
On 9/19/2017 5:45 AM, Pascal Mazon wrote: > Hi, > > The patch looks mainly ok to me. > > I'll put some comments inline. > > On 18/09/2017 20:47, Ferruh Yigit wrote: >> From: Vipin Varghese >> >> tap speed argument is not working without generating any error. > Can you describe the error, paste

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-09-19 Thread Pascal Mazon
Hi, The patch looks mainly ok to me. I'll put some comments inline. On 18/09/2017 20:47, Ferruh Yigit wrote: > From: Vipin Varghese > > tap speed argument is not working without generating any error. Can you describe the error, paste the log? > > This patch sets the configured speed during devi

[dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-09-18 Thread Ferruh Yigit
From: Vipin Varghese tap speed argument is not working without generating any error. This patch sets the configured speed during device start. Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Cc: sta...@dpdk.org Signed-off-by: Vipin Varghese --- drivers/net/tap/rte_eth_tap.c | 27