Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert

2019-06-24 Thread Thomas Monjalon
24/06/2019 13:31, Ferruh Yigit: > On 6/24/2019 10:25 AM, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > >> Sent: Wednesday, June 19, 2019 8:22 PM > >> > >> This driver had a bogus assert which could never happen. > >> This triggers "expression is

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert

2019-06-24 Thread Ferruh Yigit
On 6/24/2019 10:25 AM, Morten Brørup wrote: >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger >> Sent: Wednesday, June 19, 2019 8:22 PM >> >> This driver had a bogus assert which could never happen. >> This triggers "expression is always false warnings" with some >> compiler

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert

2019-06-24 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, June 19, 2019 8:22 PM > > This driver had a bogus assert which could never happen. > This triggers "expression is always false warnings" with some > compilers which causes build failure. > Just remove it. >

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert

2019-06-19 Thread Rasesh Mody
>From: dev On Behalf Of Stephen Hemminger >Sent: Wednesday, June 19, 2019 11:22 AM > >This driver had a bogus assert which could never happen. >This triggers "expression is always false warnings" with some compilers which >causes build failure. >Just remove it. > >Fixes: 6041aa619f9a ("net/bnx2x:

[dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert

2019-06-19 Thread Stephen Hemminger
This driver had a bogus assert which could never happen. This triggers "expression is always false warnings" with some compilers which causes build failure. Just remove it. Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status") Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_ethdev