Re: [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 1:35 PM, Ed Czeck wrote: > Queue index was incorrectly incremented with port, which > caused incorrect queue packet placement. This manifested > when port number was != 0. > > Fixes: c33d45af3633 ("net/ark: add Tx initial version") > Cc: sta...@dpdk.org > > Signed-off-by: Ed Czeck

[dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-22 Thread Ed Czeck
Queue index was incorrectly incremented with port, which caused incorrect queue packet placement. This manifested when port number was != 0. Fixes: c33d45af3633 ("net/ark: add Tx initial version") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev_rx.c | 4 +--- drivers/

Re: [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-19 Thread Ferruh Yigit
On 7/19/2019 2:07 PM, Ed Czeck wrote: > Queue index was incorrectly incremented with port, which > caused swizzling of packet placement among queues. What is "swizzling of packet placement"? 'qidx' is used to set 'phys_qid', if what the name suggest is correct it is used to access the actual ph

[dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-19 Thread Ed Czeck
Queue index was incorrectly incremented with port, which caused swizzling of packet placement among queues. This manifested when the number of configured ports was >1 and < nb_queues. Fixes: c33d45af3633 ("net/ark: add Tx initial version") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers

Re: [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-17 Thread Ferruh Yigit
On 7/16/2019 10:34 PM, Ed Czeck wrote: > Fixes: c33d45af3633 ("net/ark: add Tx initial version") > Cc: sta...@dpdk.org > > Signed-off-by: Ed Czeck Hi Ed, Can you please add some context to commit log, what was the problem, what was its impact, how this is fixed? > --- > drivers/net/ark/ark_et

[dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-16 Thread Ed Czeck
Fixes: c33d45af3633 ("net/ark: add Tx initial version") Cc: sta...@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev_rx.c | 4 +--- drivers/net/ark/ark_ethdev_tx.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net