Re: [dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions

2018-01-04 Thread Nelio Laranjeiro
On Wed, Jan 03, 2018 at 07:21:58AM -0800, Stephen Hemminger wrote: > On Wed, 3 Jan 2018 08:35:23 +0100 > Nelio Laranjeiro wrote: > > > Hi Stephen, > > > > On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > > > Since wait_to_complete is unused, don't pass it to helper functions.

Re: [dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions

2018-01-03 Thread Stephen Hemminger
On Wed, 3 Jan 2018 08:35:23 +0100 Nelio Laranjeiro wrote: > Hi Stephen, > > On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > > Since wait_to_complete is unused, don't pass it to helper functions. > > Use the standard RTE macro to indicate this is an unused parameter. > > I

Re: [dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions

2018-01-02 Thread Nelio Laranjeiro
Hi Stephen, On Tue, Jan 02, 2018 at 12:53:09PM -0800, Stephen Hemminger wrote: > Since wait_to_complete is unused, don't pass it to helper functions. > Use the standard RTE macro to indicate this is an unused parameter. I would suggest to use the (void) as it is done in the whole driver, a specif

[dpdk-dev] [PATCH 1/2] mlx5: don't pass unused argument to sub-functions

2018-01-02 Thread Stephen Hemminger
Since wait_to_complete is unused, don't pass it to helper functions. Use the standard RTE macro to indicate this is an unused parameter. Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5_ethdev.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drive