Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Stephen Hemminger
On Thu, 16 Aug 2018 16:34:12 + "Wiles, Keith" wrote: > I looked at the Coding Guide in section 1.7.2 and it states > > 1.7.2. Definitions > - The function type should be on a line by itself preceding the > function. > - The opening brace of the function body should be on a line

Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Wiles, Keith
> On Aug 16, 2018, at 10:31 AM, Stephen Hemminger > wrote: > > The hexdump code obviously came from somewhere else originally. > It is not formatted according to DPDK coding style. > > Also, drop the comment which is not useful the docbock comment > is already in the rte_hexdump.h > > Signed

Re: [dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Wiles, Keith
> On Aug 16, 2018, at 10:31 AM, Stephen Hemminger > wrote: > > The hexdump code obviously came from somewhere else originally. > It is not formatted according to DPDK coding style. > > Also, drop the comment which is not useful the docbock comment > is already in the rte_hexdump.h > > Signe

[dpdk-dev] [PATCH 1/2] hexdump: whitespace cleanup

2018-08-16 Thread Stephen Hemminger
The hexdump code obviously came from somewhere else originally. It is not formatted according to DPDK coding style. Also, drop the comment which is not useful the docbock comment is already in the rte_hexdump.h Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_hexdump.c | 10