Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-26 Thread Thomas Monjalon
26/10/2021 14:38, Ananyev, Konstantin: > > > > > > > > > There is a concern about getting efficient log report, > > > > > > > > especially when looking at CI issues. > > > > > > > > > > > > > > +1. > > > > > > > The current solution with logs is a real pain. > > > > > > > > > > > > Are you guys ta

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-26 Thread Ananyev, Konstantin
> > > > > > > There is a concern about getting efficient log report, > > > > > > > especially when looking at CI issues. > > > > > > > > > > > > +1. > > > > > > The current solution with logs is a real pain. > > > > > > > > > > Are you guys talking about problems with > > > > > app/test/sample_pac

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-26 Thread Bing Zhao
Hi David, > -Original Message- > From: David Marchand > Sent: Monday, October 25, 2021 9:32 PM > To: NBU-Contact-Thomas Monjalon > Cc: Ananyev, Konstantin ; Bing Zhao > ; Yigit, Ferruh ; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org > Subject: Re: [PATCH 1/2] ethdev: fix log level of Tx

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-25 Thread Thomas Monjalon
25/10/2021 22:29, Ananyev, Konstantin: > > > > > > > There is a concern about getting efficient log report, > > > > > > especially when looking at CI issues. > > > > > > > > > > +1. > > > > > The current solution with logs is a real pain. > > > > > > > > Are you guys talking about problems with >

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-25 Thread Ananyev, Konstantin
> > > > > There is a concern about getting efficient log report, > > > > > especially when looking at CI issues. > > > > > > > > +1. > > > > The current solution with logs is a real pain. > > > > > > Are you guys talking about problems with > > > app/test/sample_packet_forward.* David reported? >

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-25 Thread David Marchand
On Mon, Oct 25, 2021 at 3:27 PM Thomas Monjalon wrote: > > > > There is a concern about getting efficient log report, > > > > especially when looking at CI issues. > > > > > > +1. > > > The current solution with logs is a real pain. > > > > Are you guys talking about problems with > > app/test/sam

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-25 Thread Thomas Monjalon
25/10/2021 14:55, Ananyev, Konstantin: > > > > > Correctly behaving app should never call these stub functions and > > > > should never see these messages. > > > > If your app ended up inside this function, then there something really > > > > wrong is going on, > > > > that can cause app crash,

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-25 Thread Ananyev, Konstantin
> > > Correctly behaving app should never call these stub functions and should > > > never see these messages. > > > If your app ended up inside this function, then there something really > > > wrong is going on, > > > that can cause app crash, silent memory corruption, NIC HW hang, or many > >

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-25 Thread David Marchand
On Mon, Oct 25, 2021 at 11:43 AM Thomas Monjalon wrote: > > Correctly behaving app should never call these stub functions and should > > never see these messages. > > If your app ended up inside this function, then there something really > > wrong is going on, > > that can cause app crash, silen

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-25 Thread Thomas Monjalon
24/10/2021 13:48, Ananyev, Konstantin: > > > > > > When stopping a port, the data path Tx and Rx burst functions > > > should > > > > > be stopped firstly conventionally. Then the dummy functions are > > > used > > > > > to replace the callback functions provided by the PMD. > > > > > > > > > > Wh

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-24 Thread Ananyev, Konstantin
> > > > When stopping a port, the data path Tx and Rx burst functions > > should > > > > be stopped firstly conventionally. Then the dummy functions are > > used > > > > to replace the callback functions provided by the PMD. > > > > > > > > When the application stops a port without or before stop

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-23 Thread Bing Zhao
Hi Ananyev, > -Original Message- > From: Ananyev, Konstantin > Sent: Saturday, October 23, 2021 7:47 PM > To: NBU-Contact-Thomas Monjalon ; Bing Zhao > > Cc: Yigit, Ferruh ; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org > Subject: RE: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-23 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Saturday, October 23, 2021 4:33 PM > To: Bing Zhao > Cc: ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; > dev@dpdk.org; konstantin.anan...@intel.com > Subject: Re: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-23 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon > Sent: Saturday, October 23, 2021 9:33 AM > To: Bing Zhao > Cc: Yigit, Ferruh ; andrew.rybche...@oktetlabs.ru; > dev@dpdk.org; Ananyev, Konstantin > > Subject: Re: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions > > 22/10/

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-23 Thread Thomas Monjalon
22/10/2021 23:14, Bing Zhao: > When stopping a port, the data path Tx and Rx burst functions should > be stopped firstly conventionally. Then the dummy functions are used > to replace the callback functions provided by the PMD. > > When the application stops a port without or before stopping the d

[dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-22 Thread Bing Zhao
When stopping a port, the data path Tx and Rx burst functions should be stopped firstly conventionally. Then the dummy functions are used to replace the callback functions provided by the PMD. When the application stops a port without or before stopping the data path handling. The dummy functions