Re: [dpdk-dev] [PATCH 1/2] ethdev: fix adding invalid MAC addr

2017-04-06 Thread Dai, Wei
Hi, Nélio Laranjeiro Thanks for your feedback. I will change them in my next version of patch set. -Wei > -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Monday, April 3, 2017 5:18 PM > To: Dai, Wei > Cc: dev@dpdk.org; thomas.monja...@6wind.com;

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix adding invalid MAC addr

2017-04-03 Thread Nélio Laranjeiro
Hi, Please see below some comments, On Sat, Apr 01, 2017 at 04:03:16PM +0800, Wei Dai wrote: >[...] > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index 79efaaa..d61bb27 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -4630,26 +4630,30 @@ mlx4_mac_a

[dpdk-dev] [PATCH 1/2] ethdev: fix adding invalid MAC addr

2017-04-01 Thread Wei Dai
some customers find adding mac addr to VF sometimes can fail, but it is still stored in dev->data->mac_addrs[ ]. So this can lead to some errors that assumes the non-zero entry in dev->data->mac_addrs[ ] is valid. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Wei

[dpdk-dev] [PATCH 1/2] ethdev: fix adding invalid mac addr

2017-03-31 Thread Wei Dai
some customers find adding mac addr to VF sometimes can fail, but it is still stored in dev->data->mac_addrs[ ]. So this can lead to some errors that assumes the non-zero entry in dev->data->mac_addrs[ ] is valid. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Wei