Re: [dpdk-dev] [PATCH 1/2] ethdev: deduplicate functions to get link infos

On 4/8/20 1:26 AM, Thomas Monjalon wrote: > There are two function to retrieve link informations. > The only small difference is a boolean timeout parameter. > Adding a new static function, with an additional parameter, > removes the code redundancy. > > Signed-off-by: Thomas Monjalon Reviewed-b

Re: [dpdk-dev] [PATCH 1/2] ethdev: deduplicate functions to get link infos

08/04/2020 07:21, Asaf Penso: > From: Thomas Monjalon > > +static int > > +get_link_infos(uint16_t port_id, struct rte_eth_link *eth_link, int wait) > > I would recommend renaming to link_get_infos, to have the same naming > convention as rte_eth_*link_get* and rte_eth_*link_get*_nowait No strong

Re: [dpdk-dev] [PATCH 1/2] ethdev: deduplicate functions to get link infos

Thank you, Thomas, for taking care of this. PSB. Regards, Asaf Penso > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, April 8, 2020 1:27 AM > To: dev@dpdk.org > Cc: Ferruh Yigit ; Andrew Rybchenko > > Subject: [dpdk-dev] [PATCH 1/2

[dpdk-dev] [PATCH 1/2] ethdev: deduplicate functions to get link infos

There are two function to retrieve link informations. The only small difference is a boolean timeout parameter. Adding a new static function, with an additional parameter, removes the code redundancy. Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 52 ++--