Hi Thomas,
Thanks for the review,
>Subject: Re: [dpdk-dev] [PATCH 1/2] devtools: standardize script arguments
>
>Hi,
>
>Thanks for improving tooling.
>
>28/01/2020 16:02, Ciara Power:
>> range=${1:-origin/master..}
>
>If doing a real option management, range
Hi,
Thanks for improving tooling.
28/01/2020 16:02, Ciara Power:
> range=${1:-origin/master..}
If doing a real option management, range should be the remaining argument
after option parsing.
> +if [ "$range" = '--help' ] ; then
> + print_usage
Missing "exit 0" after usage.
> # convert -N
On 1/28/2020 3:02 PM, Ciara Power wrote:
> This patch modifies the arguments expected by the check-git-log script,
> to match the format of arguments for the checkpatches script. Both
> scripts now take certain argument options in the same format, making
> them easier to use.
> e.g. Both now take a
This patch modifies the arguments expected by the check-git-log script,
to match the format of arguments for the checkpatches script. Both
scripts now take certain argument options in the same format, making
them easier to use.
e.g. Both now take a commit ID range by "-r "
The checkpatches help pr
4 matches
Mail list logo
