Re: [dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-12-19 Thread Carrillo, Erik G
> > > However, if a timer expires quickly enough, there exists the > > > following race condition that causes the timer_manage() routine to > > > misinterpret a timer in CONFIG state, resulting in lost timers: > > > > > > - Thread A: > > > - starts a timer with rte_timer_reset() > > > - the tim

Re: [dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-12-18 Thread Gavin Hu (Arm Technology China)
; Subject: Re: [dpdk-dev] [PATCH 1/1] timer: fix race condition > > Who could review this fix please? > > 29/11/2018 19:53, Erik Gabriel Carrillo: > > rte_timer_manage() adds expired timers to a "run list", and walks the > > list, transitioning each timer from the PE

Re: [dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-12-18 Thread Thomas Monjalon
Who could review this fix please? 29/11/2018 19:53, Erik Gabriel Carrillo: > rte_timer_manage() adds expired timers to a "run list", and walks the > list, transitioning each timer from the PENDING to the RUNNING state. > If another lcore resets or stops the timer at precisely this > moment, the ti

[dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-11-29 Thread Erik Gabriel Carrillo
rte_timer_manage() adds expired timers to a "run list", and walks the list, transitioning each timer from the PENDING to the RUNNING state. If another lcore resets or stops the timer at precisely this moment, the timer state would instead be set to CONFIG by that other lcore, which would cause time