[dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of an ol_flag

2014-11-12 Thread Olivier MATZ
Hi Konstantin, On 11/12/2014 06:21 PM, Ananyev, Konstantin wrote: >>> This patch introduces 2 new functions rte_get_rx_ol_flag_name() >>> and rte_get_tx_ol_flag_name() that returns the name of a flag from >>> its mask. It also fixes rxonly.c to use this new functions and to >>> display the proper

[dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of an ol_flag

2014-11-12 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Monday, November 10, 2014 5:30 PM > To: Olivier Matz > Cc: dev at dpdk.org; Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong; jigsaw > at gmail.com; Ananyev, Konstantin > Subject: Re: [PATCH 06/12] mbuf: add functions to get the name o

[dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of an ol_flag

2014-11-10 Thread Olivier MATZ
Hi Bruce, Thank you for the review. On 11/10/2014 06:29 PM, Bruce Richardson wrote: >> +/** >> + * Bit Mask to indicate what bits required for building TX context > > I don't understand this first line - is it accidentally included? Right, it's a mistake, I'll remove this line. >> + * Get the

[dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of an ol_flag

2014-11-10 Thread Bruce Richardson
On Mon, Nov 10, 2014 at 04:59:20PM +0100, Olivier Matz wrote: > In test-pmd (rxonly.c), the code is able to dump the list of ol_flags. > The issue is that the list of flags in the application has to be > synchronized with the flags defined in rte_mbuf.h. > > This patch introduces 2 new functions r

[dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of an ol_flag

2014-11-10 Thread Olivier Matz
In test-pmd (rxonly.c), the code is able to dump the list of ol_flags. The issue is that the list of flags in the application has to be synchronized with the flags defined in rte_mbuf.h. This patch introduces 2 new functions rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name() that returns the