Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2021-01-14 Thread Maxime Coquelin
On 1/14/21 3:40 PM, David Marchand wrote: > On Thu, Jan 14, 2021 at 12:05 PM Maxime Coquelin > wrote: >> On 1/5/21 10:16 PM, David Marchand wrote: >>> On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin >>> wrote: This patch initiate refactoring of Virtio PCI, by introducing a new

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2021-01-14 Thread David Marchand
On Thu, Jan 14, 2021 at 12:05 PM Maxime Coquelin wrote: > On 1/5/21 10:16 PM, David Marchand wrote: > > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > > wrote: > >> > >> This patch initiate refactoring of Virtio PCI, by introducing > >> a new device structure for PCI-specific metadata. > > >

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2021-01-14 Thread Maxime Coquelin
On 1/5/21 10:16 PM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: >> >> This patch initiate refactoring of Virtio PCI, by introducing >> a new device structure for PCI-specific metadata. > > This works, but this patch seems artificial. > > The eth_virtio_de

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2021-01-05 Thread David Marchand
On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin wrote: > > This patch initiate refactoring of Virtio PCI, by introducing > a new device structure for PCI-specific metadata. This works, but this patch seems artificial. The eth_virtio_dev_init expects dev->data->dev_private to be a virtio_hw obje

Re: [dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2020-12-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, December 21, 2020 5:13 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 04/40] net/virtio: introduce PCI device metadata > > T

[dpdk-dev] [PATCH 04/40] net/virtio: introduce PCI device metadata

2020-12-20 Thread Maxime Coquelin
This patch initiate refactoring of Virtio PCI, by introducing a new device structure for PCI-specific metadata. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 2 +- drivers/net/virtio/virtio_pci.h| 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git