Re: [dpdk-dev] [PATCH 03/19] net/ice: support device and queue ops

2018-12-05 Thread Lu, Wenzhuo
Hi Rami, > -Original Message- > From: Rami Rosen [mailto:roszenr...@gmail.com] > Sent: Monday, December 3, 2018 11:24 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Yang, Qiming ; Li, Xiaoyun > ; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH 03/19] net/ice: support d

Re: [dpdk-dev] [PATCH 03/19] net/ice: support device and queue ops

2018-12-03 Thread Rami Rosen
Hi, The same comment refers also to V2 of the patch, [PATCH v2 03/20] net/ice: support device and queue ops Regards, Rami Rosen On Mon, 3 Dec 2018 at 17:24, Rami Rosen wrote: > > Hi, Wenzhuo, > > > +static int > > +ice_dev_start(struct rte_eth_dev *dev) > > +{ > > + struct rte_eth_dev_dat

Re: [dpdk-dev] [PATCH 03/19] net/ice: support device and queue ops

2018-12-03 Thread Rami Rosen
Hi, Wenzhuo, > +static int > +ice_dev_start(struct rte_eth_dev *dev) > +{ > + struct rte_eth_dev_data *data = dev->data; > + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + uint16_

[dpdk-dev] [PATCH 03/19] net/ice: support device and queue ops

2018-11-22 Thread Wenzhuo Lu
Normally when starting/stopping the device the queue should be started and stopped. Support them both in this patch. Below ops are added, dev_configure dev_start dev_stop dev_close dev_reset rx_queue_start rx_queue_stop tx_queue_start tx_queue_stop rx_queue_setup rx_queue_release tx_queue_setup tx