Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-06 Thread Andrew Rybchenko
On 9/6/19 12:24 PM, Gaëtan Rivet wrote: On Thu, Sep 05, 2019 at 07:38:23PM +0300, Andrew Rybchenko wrote: On 9/5/19 7:36 PM, Stephen Hemminger wrote: On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: + if (ret != 0) { + ERROR("Failed to apply promi

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-06 Thread Gaëtan Rivet
On Thu, Sep 05, 2019 at 07:38:23PM +0300, Andrew Rybchenko wrote: > On 9/5/19 7:36 PM, Stephen Hemminger wrote: > > On Thu, 5 Sep 2019 17:10:40 +0100 > > Andrew Rybchenko wrote: > > > > > + if (ret != 0) { > > > + ERROR("Failed to apply promiscuous mode"); > > > +

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-05 Thread Stephen Hemminger
On Thu, 5 Sep 2019 19:49:09 +0300 Andrew Rybchenko wrote: > On 9/5/19 7:40 PM, Stephen Hemminger wrote: > > On Thu, 5 Sep 2019 17:10:40 +0100 > > Andrew Rybchenko wrote: > > > >> From: Ivan Ilchenko > >> > >> rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > >> value was cha

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-05 Thread Andrew Rybchenko
On 9/5/19 7:40 PM, Stephen Hemminger wrote: On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across net/failsafe ac

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-05 Thread Stephen Hemminger
On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > value was changed from void to int, so this patch modify usage > of these functions across net/failsafe according to new return type. > > Try

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-05 Thread Andrew Rybchenko
On 9/5/19 7:36 PM, Stephen Hemminger wrote: On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: + if (ret != 0) { + ERROR("Failed to apply promiscuous mode"); + return ret; + } Just return the error as normal and le

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-05 Thread Stephen Hemminger
On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: > + if (ret != 0) { > + ERROR("Failed to apply promiscuous mode"); > + return ret; > + } Just return the error as normal and let caller deal with it. Additional logging is no

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-05 Thread Andrew Rybchenko
On 9/5/19 7:25 PM, Gaëtan Rivet wrote: Hi, On Thu, Sep 05, 2019 at 05:10:40PM +0100, Andrew Rybchenko wrote: From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across net/fails

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-05 Thread Gaëtan Rivet
Hi, On Thu, Sep 05, 2019 at 05:10:40PM +0100, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > value was changed from void to int, so this patch modify usage > of these functions across net/failsafe according to new return type

[dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

2019-09-05 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across net/failsafe according to new return type. Try to keep promiscuous mode consistent across all active devices in the case