Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-11-27 Thread Shahaf Shuler
Monday, November 27, 2017 9:34 AM, Jerin Jacob: > > > > Monday, November 27, 2017 8:35 AM, Andrew Rybchenko: > > > > I agree about the Fast free offload. However IMO such optimization can be > introduced on other series which further more optimize the performance of > such applications, what do you

Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-11-26 Thread Andrew Rybchenko
On 11/27/2017 10:03 AM, Shahaf Shuler wrote: Monday, November 27, 2017 8:35 AM, Andrew Rybchenko: Yes this is right. Not exposing the CRC offload flag means the device don’t support CRC strip toggling, however it does not explicitly say if device always strip/not. I guess device that has su

Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-11-26 Thread Jerin Jacob
-Original Message- > Date: Mon, 27 Nov 2017 07:03:54 + > From: Shahaf Shuler > To: Andrew Rybchenko , "dev@dpdk.org" > > Subject: Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev > offloads API > > Monday, November 27, 2017 8

Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-11-26 Thread Shahaf Shuler
Rybchenko [mailto:arybche...@solarflare.com] Sent: Monday, November 27, 2017 8:35 AM To: Shahaf Shuler ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API On 11/26/2017 10:41 AM, Shahaf Shuler wrote: >>+.ignore_offl

Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-11-26 Thread Andrew Rybchenko
On 11/26/2017 10:41 AM, Shahaf Shuler wrote: >>+    .ignore_offload_bitfield = 1, >>+    .offloads = DEV_RX_OFFLOAD_CRC_STRIP, > >It is not directly related to the patch. >May be I miss something, but it looks like there is no way to say that >"I always strip CRC and cannot prese

Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-11-25 Thread Shahaf Shuler
>>+.ignore_offload_bitfield = 1, >>+.offloads = DEV_RX_OFFLOAD_CRC_STRIP, > >It is not directly related to the patch. >May be I miss something, but it looks like there is no way to say that >"I always strip CRC and cannot preserve it". Yes this is right. Not exposing the C

Re: [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-11-24 Thread Andrew Rybchenko
On 11/23/2017 03:14 PM, Shahaf Shuler wrote: Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/l2fw

[dpdk-dev] [PATCH 01/39] examples/l2fwd: convert to new ethdev offloads API

2017-11-23 Thread Shahaf Shuler
Ethdev offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new API. Signed-off-by: Shahaf Shuler --- examples/l2fwd/main.c | 38 ++