Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-14 Thread Kevin Traynor
On 12/14/2016 01:54 PM, Adrien Mazarguil wrote: >> >>> + * @param[out] error >>> + * Perform verbose error reporting if not NULL. >>> + * >>> + * @return >>> + * 0 on success, a negative errno value otherwise and rte_errno is >>> set. >>> + */ >>> +int >>>

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-14 Thread Adrien Mazarguil
Hi Kevin, On Wed, Dec 14, 2016 at 11:48:04AM +, Kevin Traynor wrote: > hi Adrien, sorry for the delay > > <...> > > > Is it expected that the application or pmd will provide locking between > these functions if required? I think it's going to have to be the app. > >>> > >>> Lo

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-14 Thread Kevin Traynor
hi Adrien, sorry for the delay <...> Is it expected that the application or pmd will provide locking between these functions if required? I think it's going to have to be the app. >>> >>> Locking is indeed expected to be performed by applications. This API only >>> documents places

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-12 Thread Adrien Mazarguil
gt; To: Chandran, Sugesh > > Cc: Kevin Traynor ; dev@dpdk.org; Thomas > > Monjalon ; De Lara Guarch, Pablo > > ; Olivier Matz ; > > sugesh.chand...@intel.comn > > Subject: Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API > > > > Hi

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-12 Thread Chandran, Sugesh
Matz ; > sugesh.chand...@intel.comn > Subject: Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API > > Hi Sugesh, > > On Fri, Dec 09, 2016 at 12:18:03PM +, Chandran, Sugesh wrote: > [...] > > > > Are you going to provide any control over the initializ

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-09 Thread Adrien Mazarguil
Hi Sugesh, On Fri, Dec 09, 2016 at 12:18:03PM +, Chandran, Sugesh wrote: [...] > > > Are you going to provide any control over the initialization of NIC > > > to define the capability matrices For eg; To operate in a L3 router mode, > > software wanted to initialize the NIC port only to consid

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-09 Thread Chandran, Sugesh
omas > Monjalon ; De Lara Guarch, Pablo > ; Olivier Matz ; > sugesh.chand...@intel.comn > Subject: Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API > > Hi Sugesh, > > On Tue, Dec 06, 2016 at 06:11:38PM +, Chandran, Sugesh wrote: > [...] > >

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-08 Thread Adrien Mazarguil
On Fri, Dec 02, 2016 at 09:06:42PM +, Kevin Traynor wrote: > On 12/01/2016 08:36 AM, Adrien Mazarguil wrote: > > Hi Kevin, > > > > On Wed, Nov 30, 2016 at 05:47:17PM +, Kevin Traynor wrote: > >> Hi Adrien, > >> > >> On 11/16/2016 04:23 PM, Adrien Mazarguil wrote: > >>> This new API superse

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-08 Thread Adrien Mazarguil
Hi Sugesh, On Tue, Dec 06, 2016 at 06:11:38PM +, Chandran, Sugesh wrote: [...] > > >>> +int > > >>> +rte_flow_validate(uint8_t port_id, > > >>> + const struct rte_flow_attr *attr, > > >>> + const struct rte_flow_item pattern[], > > >>> + const st

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-08 Thread Adrien Mazarguil
Hi Beilei, On Thu, Dec 08, 2016 at 09:00:05AM +, Xing, Beilei wrote: [...] > > +/** > > + * RTE_FLOW_ITEM_TYPE_ETH > > + * > > + * Matches an Ethernet header. > > + */ > > +struct rte_flow_item_eth { > > + struct ether_addr dst; /**< Destination MAC. */ > > + struct ether_addr src; /**< So

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-08 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Thursday, November 17, 2016 12:23 AM > To: dev@dpdk.org > Cc: Thomas Monjalon ; De Lara Guarch, > Pablo ; Olivier Matz > > Subject: [dpdk-dev] [PATCH 01/22] e

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-06 Thread Chandran, Sugesh
Thomas Monjalon ; De > Lara Guarch, Pablo ; Olivier Matz > ; sugesh.chand...@intel.comn > Subject: Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API > >>>>>>Snipp > >>> + * > >>> + * Attaches a 32 bit value to packets. >

Re: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-02 Thread Kevin Traynor
On 12/01/2016 08:36 AM, Adrien Mazarguil wrote: > Hi Kevin, > > On Wed, Nov 30, 2016 at 05:47:17PM +, Kevin Traynor wrote: >> Hi Adrien, >> >> On 11/16/2016 04:23 PM, Adrien Mazarguil wrote: >>> This new API supersedes all the legacy filter types described in >>> rte_eth_ctrl.h. It is slightly

[dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-12-01 Thread Adrien Mazarguil
Hi Kevin, On Wed, Nov 30, 2016 at 05:47:17PM +, Kevin Traynor wrote: > Hi Adrien, > > On 11/16/2016 04:23 PM, Adrien Mazarguil wrote: > > This new API supersedes all the legacy filter types described in > > rte_eth_ctrl.h. It is slightly higher level and as a result relies more on > > PMDs to

[dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-11-30 Thread Kevin Traynor
Hi Adrien, On 11/16/2016 04:23 PM, Adrien Mazarguil wrote: > This new API supersedes all the legacy filter types described in > rte_eth_ctrl.h. It is slightly higher level and as a result relies more on > PMDs to process and validate flow rules. > > Benefits: > > - A unified API is easier to pro

[dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-11-18 Thread Adrien Mazarguil
g > > Cc: Thomas Monjalon ; De Lara Guarch, > > Pablo ; Olivier Matz > > > > Subject: [dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API > > > > This new API supersedes all the legacy filter types described in > > rte_eth_ctrl.h. > > It is

[dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-11-18 Thread Xing, Beilei
Hi Adrien, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Thursday, November 17, 2016 12:23 AM > To: dev at dpdk.org > Cc: Thomas Monjalon ; De Lara Guarch, > Pablo ; Olivier Matz > > Subject: [dpdk-d

[dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-11-16 Thread Adrien Mazarguil
This new API supersedes all the legacy filter types described in rte_eth_ctrl.h. It is slightly higher level and as a result relies more on PMDs to process and validate flow rules. Benefits: - A unified API is easier to program for, applications do not have to be written for a specific filter t