Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-14 Thread Wiles, Keith
> On Jul 14, 2017, at 10:54 AM, Thomas Monjalon wrote: > > 14/07/2017 17:39, Thomas Monjalon: >> 13/07/2017 08:56, Thomas Monjalon: >>> 12/07/2017 23:59, Stephen Hemminger: On Tue, 11 Jul 2017 22:33:55 +0200 Thomas Monjalon wrote: > Thank you for this script, but... it is wr

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-14 Thread Thomas Monjalon
14/07/2017 17:39, Thomas Monjalon: > 13/07/2017 08:56, Thomas Monjalon: > > 12/07/2017 23:59, Stephen Hemminger: > > > On Tue, 11 Jul 2017 22:33:55 +0200 > > > Thomas Monjalon wrote: > > > > > > > Thank you for this script, but... it is written in Perl! > > > > I don't think it is a good idea to

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-14 Thread Thomas Monjalon
13/07/2017 08:56, Thomas Monjalon: > 12/07/2017 23:59, Stephen Hemminger: > > On Tue, 11 Jul 2017 22:33:55 +0200 > > Thomas Monjalon wrote: > > > > > Thank you for this script, but... it is written in Perl! > > > I don't think it is a good idea to add yet another language to DPDK. > > > We alread

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-13 Thread Thomas Monjalon
13/07/2017 14:19, Wiles, Keith: > > > On Jul 13, 2017, at 1:56 AM, Thomas Monjalon wrote: > > > > 12/07/2017 23:59, Stephen Hemminger: > >> On Tue, 11 Jul 2017 22:33:55 +0200 > >> Thomas Monjalon wrote: > >> > >>> Thank you for this script, but... it is written in Perl! > >>> I don't think it

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-13 Thread Wiles, Keith
> On Jul 13, 2017, at 1:56 AM, Thomas Monjalon wrote: > > 12/07/2017 23:59, Stephen Hemminger: >> On Tue, 11 Jul 2017 22:33:55 +0200 >> Thomas Monjalon wrote: >> >>> Thank you for this script, but... it is written in Perl! >>> I don't think it is a good idea to add yet another language to DPDK

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-12 Thread Thomas Monjalon
12/07/2017 23:59, Stephen Hemminger: > On Tue, 11 Jul 2017 22:33:55 +0200 > Thomas Monjalon wrote: > > > Thank you for this script, but... it is written in Perl! > > I don't think it is a good idea to add yet another language to DPDK. > > We already have shell and python scripts. > > And I am not

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-12 Thread Stephen Hemminger
On Tue, 11 Jul 2017 22:33:55 +0200 Thomas Monjalon wrote: > Thank you for this script, but... it is written in Perl! > I don't think it is a good idea to add yet another language to DPDK. > We already have shell and python scripts. > And I am not sure a lot of (young) people are able to parse it

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-11 Thread Thomas Monjalon
12/07/2017 01:05, Stephen Hemminger: > On Tue, 11 Jul 2017 22:33:55 +0200 > Thomas Monjalon wrote: > > > Hi Stephen, > > > > 11/07/2017 20:55, Stephen Hemminger: > > > This is just a simple check script to find obvious duplications. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > >

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-11 Thread Stephen Hemminger
On Tue, 11 Jul 2017 22:33:55 +0200 Thomas Monjalon wrote: > Hi Stephen, > > 11/07/2017 20:55, Stephen Hemminger: > > This is just a simple check script to find obvious duplications. > > > > Signed-off-by: Stephen Hemminger > > --- > > devtools/dup_include.pl | 64 > >

Re: [dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-11 Thread Thomas Monjalon
Hi Stephen, 11/07/2017 20:55, Stephen Hemminger: > This is just a simple check script to find obvious duplications. > > Signed-off-by: Stephen Hemminger > --- > devtools/dup_include.pl | 64 > + > 1 file changed, 64 insertions(+) > create mode 1

[dpdk-dev] [PATCH 01/19] devtools: add simple script to find duplicate includes

2017-07-11 Thread Stephen Hemminger
This is just a simple check script to find obvious duplications. Signed-off-by: Stephen Hemminger --- devtools/dup_include.pl | 64 + 1 file changed, 64 insertions(+) create mode 100755 devtools/dup_include.pl diff --git a/devtools/dup_include.pl