[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-11 Thread Tan, Jianfeng
Hi, According to the proposal, I'm going to fix the definition of this API as below: /** * Retrieve the contextual information of an Ethernet device. * * @param port_id * The port identifier of the Ethernet device. * @param ptype_mask * A hint of what kind of packet type which the

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-11 Thread Ananyev, Konstantin
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Monday, January 11, 2016 7:39 AM > To: Ananyev, Konstantin; N?lio Laranjeiro; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet > type is set > > H

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-07 Thread Adrien Mazarguil
io Laranjeiro; Tan, Jianfeng; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if > > packet type is set > > > > On Wed, Jan 06, 2016 at 04:44:43PM +, Ananyev, Konstantin wrote: > > > > > > > > > > -

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-07 Thread Ananyev, Konstantin
ary 06, 2016 3:45 PM > > > To: Ananyev, Konstantin > > > Cc: N?lio Laranjeiro; Tan, Jianfeng; dev at dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if > > > packet type is set > > > > > > On Wed, Jan 06, 2016 at

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-06 Thread Adrien Mazarguil
io Laranjeiro; Tan, Jianfeng; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if > > packet type is set > > > > On Wed, Jan 06, 2016 at 02:29:07PM +, Ananyev, Konstantin wrote: > > > > > > > > > > -

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-06 Thread Ananyev, Konstantin
ry 06, 2016 10:01 AM > > > To: Ananyev, Konstantin > > > Cc: N?lio Laranjeiro; Tan, Jianfeng; dev at dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if > > > packet type is set > > > > > > On Tue, Jan 05, 201

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-06 Thread Adrien Mazarguil
io Laranjeiro; Tan, Jianfeng; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if > > packet type is set > > > > On Tue, Jan 05, 2016 at 04:50:31PM +, Ananyev, Konstantin wrote: > > [...] > > > > -Original Mes

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-06 Thread Ananyev, Konstantin
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > Sent: Wednesday, January 06, 2016 10:01 AM > To: Ananyev, Konstantin > Cc: N?lio Laranjeiro; Tan, Jianfeng; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add AP

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-06 Thread Adrien Mazarguil
On Tue, Jan 05, 2016 at 04:50:31PM +, Ananyev, Konstantin wrote: [...] > > -Original Message- > > From: N?lio Laranjeiro [mailto:nelio.laranjeiro at 6wind.com] [...] > > I think we miss a comment here in how those 2/6/4 values are chosen > > because, according to the mask, I expect 16 p

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-05 Thread Nélio Laranjeiro
v at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if > > packet type is set > > > > I'm not sure about the usefulness of this new callback, but one issue I see > > with rte_eth_dev_get_ptype_info() is that determining the pr

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-05 Thread Ananyev, Konstantin
Monday, January 04, 2016 11:38 AM > > > To: Tan, Jianfeng > > > Cc: dev at dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if > > > packet type is set > > > > > > I'm not sure about the usefulness of

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-04 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Monday, January 04, 2016 11:38 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet > typ

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2016-01-04 Thread Adrien Mazarguil
I'm not sure about the usefulness of this new callback, but one issue I see with rte_eth_dev_get_ptype_info() is that determining the proper size for ptypes[] according to a mask is awkward. For instance suppose RTE_PTYPE_L4_MASK is redefined to a different size at some point, the caller must dynam

[dpdk-dev] [PATCH 01/12] ethdev: add API to query what/if packet type is set

2015-12-31 Thread Jianfeng Tan
Add a new API rte_eth_dev_get_ptype_info to query what/if packet type will be set by current rx burst function. Signed-off-by: Jianfeng Tan --- lib/librte_ether/rte_ethdev.c | 12 lib/librte_ether/rte_ethdev.h | 22 ++ lib/librte_mbuf/rte_mbuf.h| 13 +