Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-29 Thread Gaëtan Rivet
; Archbold, Brian > > ; Kenny, Emma ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry > > infrastructure > > > > Hi Ciara, > > > > On Thu, Aug 23, 2018 at 01:08:03PM +0100, Ciara Power wrote: > > > This patch

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-28 Thread Van Haaren, Harry
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, August 24, 2018 12:22 AM > To: Power, Ciara > Cc: Van Haaren, Harry ; Archbold, Brian > ; Kenny, Emma ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry > infrastru

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-28 Thread Van Haaren, Harry
Hi Gaetan, > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Tuesday, August 28, 2018 12:47 PM > To: Power, Ciara > Cc: Van Haaren, Harry ; Archbold, Brian > ; Kenny, Emma ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemet

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-28 Thread Van Haaren, Harry
> From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Friday, August 24, 2018 2:04 PM > To: Power, Ciara ; Van Haaren, Harry > ; Archbold, Brian ; > Kenny, Emma > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry > infrastruc

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-28 Thread Gaëtan Rivet
Hi Ciara, On Thu, Aug 23, 2018 at 01:08:03PM +0100, Ciara Power wrote: > This patch adds the infrastructure and initial code for the > telemetry library. > > A virtual device is used for telemetry, which is included in > this patch. To use telemetry, a command-line argument must be > used - "--vd

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-24 Thread Shreyansh Jain
On Thursday 23 August 2018 05:38 PM, Ciara Power wrote: This patch adds the infrastructure and initial code for the telemetry library. A virtual device is used for telemetry, which is included in this patch. To use telemetry, a command-line argument must be used - "--vdev=telemetry". Control th

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-23 Thread Stephen Hemminger
On Thu, 23 Aug 2018 13:08:03 +0100 Ciara Power wrote: > +/* Logging Macros */ > +extern int telemetry_log_level; > + > +#define TELEMETRY_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ##level, telemetry_log_level, "%s(): "fmt "\n", \ > + __func__, ##args) > + > +#define TELEMETR

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-23 Thread Stephen Hemminger
On Thu, 23 Aug 2018 13:08:03 +0100 Ciara Power wrote: > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > + > +#include > + > +#ifndef _RTE_TELEMETRY_H_ > +#define _RTE_TELEMETRY_H_ > + > +/** > + * Get the telemetry_impl structure device pointer initia

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-23 Thread Stephen Hemminger
On Thu, 23 Aug 2018 13:08:03 +0100 Ciara Power wrote: > + TELEMETRY_LOG_ERR("Error - Calling thread could not be" > + " put to sleep\n"); Don't break strings across lines. It makes it harder for developers who want to use tools to look for log mess

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-23 Thread Stephen Hemminger
On Thu, 23 Aug 2018 13:08:03 +0100 Ciara Power wrote: > +static int32_t > +rte_telemetry_run(void *userdata) > +{ > + struct telemetry_impl *telemetry = (struct telemetry_impl *)userdata; Casting a void * pointer is unnecessary in C. Assignment has an implicit cast.

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-23 Thread Stephen Hemminger
On Thu, 23 Aug 2018 13:08:03 +0100 Ciara Power wrote: > + > +static int > +telemetry_probe(struct rte_vdev_device *vdev) > +{ > + int ret; > + > + RTE_SET_USED(vdev); > + ret = rte_telemetry_init(rte_socket_id()); > + if (ret < 0) { > + printf("Error - Telemetry initia

[dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-23 Thread Ciara Power
This patch adds the infrastructure and initial code for the telemetry library. A virtual device is used for telemetry, which is included in this patch. To use telemetry, a command-line argument must be used - "--vdev=telemetry". Control threads are used to get CPU cycles for telemetry, which are