Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 7:14 PM, Alejandro Lucero wrote: > On Thu, Apr 26, 2018 at 4:42 PM, Stephen Hemminger < > step...@networkplumber.org> wrote: > >> On Thu, 26 Apr 2018 13:52:53 +0100 >> Alejandro Lucero wrote: >> >>> Hi Stephen, >>> >>> Thanks for this patch set. >>> >>> I'm happy with it although I h

Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes

2018-04-26 Thread Alejandro Lucero
On Thu, Apr 26, 2018 at 4:42 PM, Stephen Hemminger < step...@networkplumber.org> wrote: > On Thu, 26 Apr 2018 13:52:53 +0100 > Alejandro Lucero wrote: > > > Hi Stephen, > > > > Thanks for this patch set. > > > > I'm happy with it although I have some concerns regarding how the dynamic > > logs wo

Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes

2018-04-26 Thread Stephen Hemminger
On Thu, 26 Apr 2018 13:52:53 +0100 Alejandro Lucero wrote: > Hi Stephen, > > Thanks for this patch set. > > I'm happy with it although I have some concerns regarding how the dynamic > logs work, or maybe I have a wrong understanding about it. I have tried to > read some doc about how it works,

Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes

2018-04-26 Thread Alejandro Lucero
Hi Stephen, Thanks for this patch set. I'm happy with it although I have some concerns regarding how the dynamic logs work, or maybe I have a wrong understanding about it. I have tried to read some doc about how it works, and I found the original patch from Olivier the best source, so maybe thing

[dpdk-dev] [PATCH 0/5] net/nfp logging fixes

2018-04-25 Thread Stephen Hemminger
These are several small changes to make the Netronome driver use logging macros in the same way as other drivers. Compile tested only. I don't have Netronome hardware. Stephen Hemminger (5): net/nfp: use correct logtype for init messages net/nfp: add implied new line to PMD_DRV_LOG net/nfp: