Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage

2020-10-28 Thread David Marchand
On Wed, Oct 28, 2020 at 4:17 PM David Marchand wrote: > This fixes it: > @@ -37,11 +37,12 @@ meta_copy(char **meta, int *offset, char *str, int rc) > if (rc < 0) > return rc; > > - ptr = realloc(ptr, count + rc); > + ptr = realloc(ptr, count + rc + 1); >

Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage

2020-10-28 Thread David Marchand
On Wed, Oct 28, 2020 at 2:09 PM David Marchand wrote: > > echo "trace_autotest" | ./build/app/test/dpdk-test -c 0x3 --trace=.* > > --no-huge --trace=.* > > Err, indeed, thanks for catching. > I did some diff on metadata files, but did not notice this trailing character. > > This is an issue with

Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage

2020-10-28 Thread David Marchand
On Wed, Oct 28, 2020 at 9:53 AM Jerin Jacob wrote: > > On Wed, Oct 28, 2020 at 1:13 AM David Marchand > wrote: > > > > On Fri, Oct 23, 2020 at 10:01 AM David Marchand > > wrote: > > > > > > Following recent increase of an internal array that was limiting CTF event > > > descriptions, I had a sec

Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage

2020-10-28 Thread Jerin Jacob
On Wed, Oct 28, 2020 at 1:13 AM David Marchand wrote: > > On Fri, Oct 23, 2020 at 10:01 AM David Marchand > wrote: > > > > Following recent increase of an internal array that was limiting CTF event > > descriptions, I had a second look at the code. > > All of this is slow path, so I see no reason

Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage

2020-10-27 Thread David Marchand
On Fri, Oct 23, 2020 at 10:01 AM David Marchand wrote: > > Following recent increase of an internal array that was limiting CTF event > descriptions, I had a second look at the code. > All of this is slow path, so I see no reason in keeping this limitation > and we can go with dynamic allocations.

[dpdk-dev] [PATCH 0/3] Rework CTF event description storage

2020-10-23 Thread David Marchand
Following recent increase of an internal array that was limiting CTF event descriptions, I had a second look at the code. All of this is slow path, so I see no reason in keeping this limitation and we can go with dynamic allocations. While at it, I tweaked the metadata file output. I consider thi