Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-16 Thread Igor Russkikh
> These are new ethdev APIs, not driver code, that have been sent after > rc1, so > these didn't go through a proper review cycle, we didn't get any comment > on any > other possible driver can use it, I am for postponing the series to next > release. > > Also th

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-16 Thread Thomas Monjalon
16/04/2019 11:58, Andrew Rybchenko: > On 4/16/19 12:43 PM, Ferruh Yigit wrote: > > On 4/13/2019 8:24 AM, Igor Russkikh wrote: > >> Hi Ferruh, > >> > +int > +rte_eth_macsec_select_txsa(uint16_t port_id, > + uint8_t idx, uint8_t an, > +

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-16 Thread Andrew Rybchenko
On 4/16/19 12:43 PM, Ferruh Yigit wrote: On 4/13/2019 8:24 AM, Igor Russkikh wrote: Hi Ferruh, +int +rte_eth_macsec_select_txsa(uint16_t port_id, + uint8_t idx, uint8_t an, + uint32_t pn, uint8_t *key); + #include These are new ethdev

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-16 Thread Ferruh Yigit
On 4/13/2019 8:24 AM, Igor Russkikh wrote: > Hi Ferruh, > >>> +int >>> +rte_eth_macsec_select_txsa(uint16_t port_id, >>> + uint8_t idx, uint8_t an, >>> + uint32_t pn, uint8_t *key); >>> + >>> >>> #include >>> >> >> These are new ethdev APIs, not driv

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-13 Thread Igor Russkikh
Hi Ferruh, >> +int >> +rte_eth_macsec_select_txsa(uint16_t port_id, >> + uint8_t idx, uint8_t an, >> + uint32_t pn, uint8_t *key); >> + >> >> #include >> > > These are new ethdev APIs, not driver code, that have been sent after rc1, so > these did

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 12:18 PM, Igor Russkikh wrote: > MACSEC related device ops, API and parameters are taken from the > existing ixgbe PMD ops > > Signed-off-by: Igor Russkikh <...> > @@ -3872,6 +3872,121 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, > const char *pool); > void * > rte_eth_de

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-12 Thread Thomas Monjalon
12/04/2019 10:50, Igor Russkikh: > > >>> Please can you explain how it is related to rte_security? > >> > >> It is not. > >> Do you mean macsec control API could be moved and logically be a part of > >> rte_security api? > >> I can't comment now on how feasible is this. Moreover this depends on h

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-12 Thread Igor Russkikh
>>> Please can you explain how it is related to rte_security? >> >> It is not. >> Do you mean macsec control API could be moved and logically be a part of >> rte_security api? >> I can't comment now on how feasible is this. Moreover this depends on how >> Intel considers >> and uses the existing

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-11 Thread Thomas Monjalon
11/04/2019 14:37, Igor Russkikh: > On 10.04.2019 14:46, Thomas Monjalon wrote: > > 10/04/2019 13:18, Igor Russkikh: > >> MACSEC related device ops, API and parameters are taken from the > >> existing ixgbe PMD ops > > > > Please can you explain how it is related to rte_security? > > It is not. >

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-11 Thread Igor Russkikh
Hello Thomas, Thanks for the review! On 10.04.2019 14:46, Thomas Monjalon wrote: > 10/04/2019 13:18, Igor Russkikh: >> MACSEC related device ops, API and parameters are taken from the >> existing ixgbe PMD ops > > Please can you explain how it is related to rte_security? It is not. Do you mean

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-10 Thread Thomas Monjalon
10/04/2019 13:18, Igor Russkikh: > MACSEC related device ops, API and parameters are taken from the > existing ixgbe PMD ops Please can you explain how it is related to rte_security?

[dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-10 Thread Igor Russkikh
MACSEC related device ops, API and parameters are taken from the existing ixgbe PMD ops Signed-off-by: Igor Russkikh --- lib/librte_ethdev/rte_ethdev.c | 87 + lib/librte_ethdev/rte_ethdev.h | 115 lib/librte_ethdev/rte_ethdev_core.h |