[dpdk-dev] [PATCH] virtio: prettify log messages

2016-02-11 Thread Vincent JARDIN
On 11/02/2016 02:12, Stephen Hemminger wrote: > I would rather the macros were aligned with ixgbe which always > adds newline for all the PMD_XXX_LOG() macros. And then remove > all extra newlines in virtio code. you right

[dpdk-dev] [PATCH] virtio: prettify log messages

2016-02-11 Thread Vincent JARDIN
PMD_TX_LOG() looks better with a \n Signed-off-by: Vincent JARDIN --- drivers/net/virtio/virtio_rxtx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 41a1366..c03d36a 100644 --- a/drivers/

[dpdk-dev] [PATCH] virtio: prettify log messages

2016-02-10 Thread Stephen Hemminger
On Thu, 11 Feb 2016 00:45:34 +0100 Vincent JARDIN wrote: > PMD_TX_LOG() looks better with a \n > > Signed-off-by: Vincent JARDIN NAK. Yes the messages, are messed up, but this is not the right way to fix it. The logging wrappers are inconsistent in virtio. PMD_INIT_LOG adds newline, but RX/TX