[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-03-10 Thread Kyle Larose
On Wed, Mar 9, 2016 at 4:37 PM, Bruce Richardson wrote: > On Fri, Mar 04, 2016 at 08:25:07AM -0500, Kyle Larose wrote: >> On Fri, Mar 4, 2016 at 3:11 AM, Tom Kiely wrote: >> > Sure. >> >Tom >> > >> > >> > On 03/04/2016 06:16 AM, Xie, Huawei wrote: >> >> >> >> On 2/23/2016 12:23 AM, Tom Kiely

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-03-09 Thread Bruce Richardson
On Fri, Mar 04, 2016 at 08:25:07AM -0500, Kyle Larose wrote: > On Fri, Mar 4, 2016 at 3:11 AM, Tom Kiely wrote: > > Sure. > >Tom > > > > > > On 03/04/2016 06:16 AM, Xie, Huawei wrote: > >> > >> On 2/23/2016 12:23 AM, Tom Kiely wrote: > >>> > >>> Hi, > >>> Sorry I missed the last few messa

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-03-04 Thread Kyle Larose
On Fri, Mar 4, 2016 at 3:11 AM, Tom Kiely wrote: > Sure. >Tom > > > On 03/04/2016 06:16 AM, Xie, Huawei wrote: >> >> On 2/23/2016 12:23 AM, Tom Kiely wrote: >>> >>> Hi, >>> Sorry I missed the last few messages until now. I'm happy with >>> just removing the "if". Kyle, when you say you fi

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-03-04 Thread Tom Kiely
Sure. Tom On 03/04/2016 06:16 AM, Xie, Huawei wrote: > On 2/23/2016 12:23 AM, Tom Kiely wrote: >> Hi, >> Sorry I missed the last few messages until now. I'm happy with >> just removing the "if". Kyle, when you say you fixed it, do you mean >> that you will push the patch or have already d

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-03-04 Thread Xie, Huawei
On 2/23/2016 12:23 AM, Tom Kiely wrote: > Hi, > Sorry I missed the last few messages until now. I'm happy with > just removing the "if". Kyle, when you say you fixed it, do you mean > that you will push the patch or have already done so ? >Thanks, >Tom Could you please send the pat

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-02-26 Thread Kyle Larose
Virtio has an mbuf descriptor ring containing mbufs to be used for receiving traffic. When the host queues traffic to be sent to the guest, it consumes these descriptors. If none exist, it discards the packet. The virtio pmd allocates mbufs to the descriptor ring every time it succesfully receives

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-02-23 Thread Xie, Huawei
On 2/23/2016 12:23 AM, Tom Kiely wrote: > Hi, > Sorry I missed the last few messages until now. I'm happy with > just removing the "if". Kyle, when you say you fixed it, do you mean > that you will push the patch or have already done so ? >Thanks, >Tom > > On 02/18/2016 02:03 PM, Ky

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-02-22 Thread Tom Kiely
Hi, Sorry I missed the last few messages until now. I'm happy with just removing the "if". Kyle, when you say you fixed it, do you mean that you will push the patch or have already done so ? Thanks, Tom On 02/18/2016 02:03 PM, Kyle Larose wrote: > On Tue, Jan 5, 2016 at 2:13 AM,

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-02-18 Thread Kyle Larose
On Tue, Jan 5, 2016 at 2:13 AM, Xie, Huawei wrote: > On 12/17/2015 7:18 PM, Tom Kiely wrote: >> >> >> On 11/25/2015 05:32 PM, Xie, Huawei wrote: >>> On 11/13/2015 5:33 PM, Tom Kiely wrote: If all rx descriptors are processed while transient mbuf exhaustion is present, the rx ring ends up

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-02-10 Thread Bruce Richardson
On Tue, Jan 05, 2016 at 07:13:04AM +, Xie, Huawei wrote: > On 12/17/2015 7:18 PM, Tom Kiely wrote: > > > > > > On 11/25/2015 05:32 PM, Xie, Huawei wrote: > >> On 11/13/2015 5:33 PM, Tom Kiely wrote: > >>> If all rx descriptors are processed while transient > >>> mbuf exhaustion is present, the

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2016-01-05 Thread Xie, Huawei
On 12/17/2015 7:18 PM, Tom Kiely wrote: > > > On 11/25/2015 05:32 PM, Xie, Huawei wrote: >> On 11/13/2015 5:33 PM, Tom Kiely wrote: >>> If all rx descriptors are processed while transient >>> mbuf exhaustion is present, the rx ring ends up with >>> no available descriptors. Thus no packets are rece

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-12-17 Thread Tom Kiely
On 11/25/2015 05:32 PM, Xie, Huawei wrote: > On 11/13/2015 5:33 PM, Tom Kiely wrote: >> If all rx descriptors are processed while transient >> mbuf exhaustion is present, the rx ring ends up with >> no available descriptors. Thus no packets are received >> on that ring. Since descriptor refill is

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-12-17 Thread Tom Kiely
Hi, Sorry for the delay. I have been occupied on another critical issue. I'll look at this today. Tom On 12/17/2015 04:47 AM, Xie, Huawei wrote: > On 11/26/2015 1:33 AM, Xie, Huawei wrote: >> On 11/13/2015 5:33 PM, Tom Kiely wrote: >>> If all rx descriptors are processed while transient >

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-12-17 Thread Xie, Huawei
On 11/26/2015 1:33 AM, Xie, Huawei wrote: > On 11/13/2015 5:33 PM, Tom Kiely wrote: >> If all rx descriptors are processed while transient >> mbuf exhaustion is present, the rx ring ends up with >> no available descriptors. Thus no packets are received >> on that ring. Since descriptor refill is pe

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-11-25 Thread Xie, Huawei
On 11/13/2015 5:33 PM, Tom Kiely wrote: > If all rx descriptors are processed while transient > mbuf exhaustion is present, the rx ring ends up with > no available descriptors. Thus no packets are received > on that ring. Since descriptor refill is performed post > rx descriptor processing, in this

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-11-25 Thread Yuanhan Liu
On Tue, Nov 24, 2015 at 10:20:22PM +0100, Thomas Monjalon wrote: > Any review, please? Huawei, would you review it? Sorry that I've not read too much code about virtio PMD driver yet. --yliu > 2015-11-13 09:30, Tom Kiely: > > If all rx descriptors are processed while transient > > mbuf

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-11-25 Thread Xie, Huawei
On 11/25/2015 9:47 AM, Yuanhan Liu wrote: > On Tue, Nov 24, 2015 at 10:20:22PM +0100, Thomas Monjalon wrote: >> Any review, please? > Huawei, would you review it? Sorry that I've not read too much > code about virtio PMD driver yet. Np. will do it by end of this week. > > --yliu > > >> 2015-1

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-11-24 Thread Thomas Monjalon
Any review, please? 2015-11-13 09:30, Tom Kiely: > If all rx descriptors are processed while transient > mbuf exhaustion is present, the rx ring ends up with > no available descriptors. Thus no packets are received > on that ring. Since descriptor refill is performed post > rx descriptor processin

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-11-13 Thread Tom Kiely
If all rx descriptors are processed while transient mbuf exhaustion is present, the rx ring ends up with no available descriptors. Thus no packets are received on that ring. Since descriptor refill is performed post rx descriptor processing, in this case no refill is ever subsequently performed res