Re: [dpdk-dev] [PATCH] vhost: flush IOTLB cache on new mem table handling

2018-08-02 Thread Maxime Coquelin
On 08/02/2018 07:09 PM, Stephen Hemminger wrote: On Thu, 2 Aug 2018 18:37:27 +0200 Maxime Coquelin wrote: +void +vhost_user_iotlb_flush_all(struct vhost_virtqueue *vq) +{ + vhost_user_iotlb_cache_remove_all(vq); + vhost_user_iotlb_pending_remove_all(vq); +} +

Re: [dpdk-dev] [PATCH] vhost: flush IOTLB cache on new mem table handling

2018-08-02 Thread Stephen Hemminger
On Thu, 2 Aug 2018 18:37:27 +0200 Maxime Coquelin wrote: > > +void > +vhost_user_iotlb_flush_all(struct vhost_virtqueue *vq) > +{ > + vhost_user_iotlb_cache_remove_all(vq); > + vhost_user_iotlb_pending_remove_all(vq); > +} > + Wrong indentation, you don't want two tabs

[dpdk-dev] [PATCH] vhost: flush IOTLB cache on new mem table handling

2018-08-02 Thread Maxime Coquelin
IOTLB entries contain the host virtual address of the guest pages. When receiving a new VHOST_USER_SET_MEM_TABLE request, the previous regions get unmapped, so the IOTLB entries, if any, will be invalid. It does cause the vhost-user process to segfault. This patch introduces a new function to flus