Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-17 Thread Xia, Chenbo
Hi David, > -Original Message- > From: David Marchand > Sent: Thursday, May 13, 2021 10:12 PM > To: Xia, Chenbo ; Maxime Coquelin > > Cc: dev ; Kevin Traynor ; Pei Zhang > ; Yigit, Ferruh ; Thomas > Monjalon > Subject: Re: [PATCH] vhost: fix wrong IOTLB initialization > > On Thu, May 1

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-14 Thread Thomas Monjalon
14/05/2021 11:09, Ferruh Yigit: > On 5/14/2021 9:18 AM, David Marchand wrote: > > On Thu, May 13, 2021 at 5:04 PM Ferruh Yigit wrote: > >>> If you choose to revert, we can ask Red Hat QA to test RC3 without > >>> further delay. Please let us know when you consider the options. > >>> > >> > >> If t

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-14 Thread Ferruh Yigit
On 5/14/2021 9:18 AM, David Marchand wrote: > On Thu, May 13, 2021 at 5:04 PM Ferruh Yigit wrote: >>> If you choose to revert, we can ask Red Hat QA to test RC3 without >>> further delay. Please let us know when you consider the options. >>> >> >> If the patch is not good to go as it is I suggest

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-14 Thread David Marchand
On Thu, May 13, 2021 at 5:04 PM Ferruh Yigit wrote: > > If you choose to revert, we can ask Red Hat QA to test RC3 without > > further delay. Please let us know when you consider the options. > > > > If the patch is not good to go as it is I suggest reverting it, as far as I > know > Chenbo will

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-14 Thread David Marchand
On Thu, May 13, 2021 at 4:11 PM David Marchand wrote: > On Thu, May 13, 2021 at 2:38 PM Chenbo Xia wrote: > > > > This patch fixes an issue of application crash because of vhost iotlb > > not initialized when virtio has multiqueue enabled. > > > > iotlb messages will be sent when some queues are

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-13 Thread Ferruh Yigit
On 5/13/2021 3:38 PM, Kevin Traynor wrote: > On 13/05/2021 15:11, David Marchand wrote: >> On Thu, May 13, 2021 at 2:38 PM Chenbo Xia wrote: >>> >>> This patch fixes an issue of application crash because of vhost iotlb >>> not initialized when virtio has multiqueue enabled. >>> >>> iotlb messages

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-13 Thread Kevin Traynor
On 13/05/2021 15:11, David Marchand wrote: > On Thu, May 13, 2021 at 2:38 PM Chenbo Xia wrote: >> >> This patch fixes an issue of application crash because of vhost iotlb >> not initialized when virtio has multiqueue enabled. >> >> iotlb messages will be sent when some queues are not enabled. If w

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-13 Thread David Marchand
On Thu, May 13, 2021 at 2:38 PM Chenbo Xia wrote: > > This patch fixes an issue of application crash because of vhost iotlb > not initialized when virtio has multiqueue enabled. > > iotlb messages will be sent when some queues are not enabled. If we > initialize iotlb in vhost_user_set_vring_num,

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-13 Thread Kevin Traynor
On 13/05/2021 14:10, Ferruh Yigit wrote: > On 5/13/2021 1:28 PM, Chenbo Xia wrote: >> This patch fixes an issue of application crash because of vhost iotlb >> not initialized when virtio has multiqueue enabled. >> >> iotlb messages will be sent when some queues are not enabled. If we >> initialize

Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-13 Thread Ferruh Yigit
On 5/13/2021 1:28 PM, Chenbo Xia wrote: > This patch fixes an issue of application crash because of vhost iotlb > not initialized when virtio has multiqueue enabled. > > iotlb messages will be sent when some queues are not enabled. If we > initialize iotlb in vhost_user_set_vring_num, it could hap

[dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization

2021-05-13 Thread Chenbo Xia
This patch fixes an issue of application crash because of vhost iotlb not initialized when virtio has multiqueue enabled. iotlb messages will be sent when some queues are not enabled. If we initialize iotlb in vhost_user_set_vring_num, it could happen that iotlb update comes when iotlb pool of dis