Re: [dpdk-dev] [PATCH] vhost: fix dequeue zero copy not work with virtio1

2017-12-19 Thread Zhao, Bing
On 2017/12/15 20:48, Yuanhan Liu wrote: On Fri, Dec 15, 2017 at 10:33:41AM +, Loftus, Ciara wrote: >> >> Hi Junjie, >> >> On 12/13/2017 05:50 PM, Junjie Chen wrote: >>> This fix dequeue zero copy can not work with Qemu >>> version >= 2.7. Since from Qemu 2.7 virtio device >>> use virtio-1 pro

Re: [dpdk-dev] [PATCH] vhost: fix dequeue zero copy not work with virtio1

2017-12-15 Thread Yuanhan Liu
On Fri, Dec 15, 2017 at 10:33:41AM +, Loftus, Ciara wrote: > > > > Hi Junjie, > > > > On 12/13/2017 05:50 PM, Junjie Chen wrote: > > > This fix dequeue zero copy can not work with Qemu > > > version >= 2.7. Since from Qemu 2.7 virtio device > > > use virtio-1 protocol, the zero copy code path

Re: [dpdk-dev] [PATCH] vhost: fix dequeue zero copy not work with virtio1

2017-12-15 Thread Loftus, Ciara
> > Hi Junjie, > > On 12/13/2017 05:50 PM, Junjie Chen wrote: > > This fix dequeue zero copy can not work with Qemu > > version >= 2.7. Since from Qemu 2.7 virtio device > > use virtio-1 protocol, the zero copy code path > > forget to add offset to buffer address. > > > > Signed-off-by: Junjie Ch

Re: [dpdk-dev] [PATCH] vhost: fix dequeue zero copy not work with virtio1

2017-12-13 Thread Maxime Coquelin
Hi Junjie, On 12/13/2017 05:50 PM, Junjie Chen wrote: This fix dequeue zero copy can not work with Qemu version >= 2.7. Since from Qemu 2.7 virtio device use virtio-1 protocol, the zero copy code path forget to add offset to buffer address. Signed-off-by: Junjie Chen --- lib/librte_vhost/vir

[dpdk-dev] [PATCH] vhost: fix dequeue zero copy not work with virtio1

2017-12-13 Thread Junjie Chen
This fix dequeue zero copy can not work with Qemu version >= 2.7. Since from Qemu 2.7 virtio device use virtio-1 protocol, the zero copy code path forget to add offset to buffer address. Signed-off-by: Junjie Chen --- lib/librte_vhost/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele

Re: [dpdk-dev] [PATCH] vhost: fix dequeue zero copy

2017-04-19 Thread Yuanhan Liu
On Wed, Apr 19, 2017 at 01:26:01PM +0800, Yuanhan Liu wrote: > For zero copy mode, we need pin the mbuf to not let the underlaying PMD > driver (or the app) free the mbuf. Currently, only the heading mbuf is > pinned. However, the mbuf free function would try to free all mbufs > in the mbuf chain (

[dpdk-dev] [PATCH] vhost: fix dequeue zero copy

2017-04-18 Thread Yuanhan Liu
For zero copy mode, we need pin the mbuf to not let the underlaying PMD driver (or the app) free the mbuf. Currently, only the heading mbuf is pinned. However, the mbuf free function would try to free all mbufs in the mbuf chain (-1 to the refcnt). This may lead the head mbuf being still pinned, wh