Re: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close

2017-08-22 Thread Jens Freimann
On Tue, Aug 22, 2017 at 01:58:44PM +0200, Jens Freimann wrote: On Tue, Aug 22, 2017 at 09:55:19AM +, Stojaczyk, DariuszX wrote: Do we need a documentation change for this? To answer my own question, I think doc/guides/prog_guide/vhost_lib.rst needs an update. regards, Jens regards, Jen

Re: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close

2017-08-22 Thread Jens Freimann
On Tue, Aug 22, 2017 at 09:55:19AM +, Stojaczyk, DariuszX wrote: Hi Jens, I'm a little uncertain but my gut feeling is that in this context a connection is something between two sockets, not between devices. What do you mean? This is a unix domain socket connection. DPDK can create the s

Re: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close

2017-08-22 Thread Stojaczyk, DariuszX
Hi Jens, > I'm a little uncertain but my gut feeling is that in this context a > connection is > something between two sockets, not between devices. What do you mean? This is a unix domain socket connection. DPDK can create the socket, then the client may connect to it via connect(2). > I woul

Re: [dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close

2017-08-21 Thread Jens Freimann
Hi Dariusz, On Mon, Aug 21, 2017 at 11:34:42AM +0200, Dariusz Stojaczyk wrote: When user receives destroy_device signal, he does not know *why* that event happened. He does not differ between socket shutdown and virtio processing pause. User could completely delete device during transition from

[dpdk-dev] [PATCH] vhost: added user callbacks for socket open/close

2017-08-20 Thread Dariusz Stojaczyk
When user receives destroy_device signal, he does not know *why* that event happened. He does not differ between socket shutdown and virtio processing pause. User could completely delete device during transition from BIOS to kernel, causing freeze or possibly kernel panic. Instead of changing new_d