Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-10-15 Thread David Marchand
On Mon, Oct 14, 2019 at 4:47 PM David Marchand wrote: > > On Mon, Oct 14, 2019 at 3:49 PM Harris, James R > wrote: > > On 10/14/19, 4:18 AM, "David Marchand" wrote: > > > > On Fri, Aug 16, 2019 at 9:19 PM Jim Harris > > wrote: > > > > > > The code checks both rte_mp_request_sync()

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-10-14 Thread Harris, James R
> On Oct 14, 2019, at 7:47 AM, David Marchand wrote: > > On Mon, Oct 14, 2019 at 3:49 PM Harris, James R > wrote: >> On 10/14/19, 4:18 AM, "David Marchand" wrote: >> >>>On Fri, Aug 16, 2019 at 9:19 PM Jim Harris >>> wrote: >>> >>> The code checks both rte_mp_request_sync() return >>

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-10-14 Thread David Marchand
On Mon, Oct 14, 2019 at 3:49 PM Harris, James R wrote: > On 10/14/19, 4:18 AM, "David Marchand" wrote: > > On Fri, Aug 16, 2019 at 9:19 PM Jim Harris > wrote: > > > > The code checks both rte_mp_request_sync() return > > code and that the number of messages in the reply > >

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-10-14 Thread Harris, James R
On 10/14/19, 4:18 AM, "David Marchand" wrote: On Fri, Aug 16, 2019 at 9:19 PM Jim Harris wrote: > > The code checks both rte_mp_request_sync() return > code and that the number of messages in the reply > equals 1. If rte_mp_request_sync() succeeds but > there was more

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-10-14 Thread David Marchand
On Fri, Aug 16, 2019 at 9:19 PM Jim Harris wrote: > > The code checks both rte_mp_request_sync() return > code and that the number of messages in the reply > equals 1. If rte_mp_request_sync() succeeds but > there was more than one message, those messages > would get leaked. > > Found via code re

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-08-20 Thread Burakov, Anatoly
On 20-Aug-19 2:16 PM, Harris, James R wrote: On Aug 20, 2019, at 6:13 AM, Burakov, Anatoly wrote: On 16-Aug-19 1:13 PM, Jim Harris wrote: The code checks both rte_mp_request_sync() return code and that the number of messages in the reply equals 1. If rte_mp_request_sync() succeeds but ther

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-08-20 Thread Harris, James R
> On Aug 20, 2019, at 6:13 AM, Burakov, Anatoly > wrote: > >> On 16-Aug-19 1:13 PM, Jim Harris wrote: >> The code checks both rte_mp_request_sync() return >> code and that the number of messages in the reply >> equals 1. If rte_mp_request_sync() succeeds but >> there was more than one messag

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-08-20 Thread Burakov, Anatoly
On 16-Aug-19 1:13 PM, Jim Harris wrote: The code checks both rte_mp_request_sync() return code and that the number of messages in the reply equals 1. If rte_mp_request_sync() succeeds but there was more than one message, those messages would get leaked. Found via code review by Anatoly Burakov

[dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-08-16 Thread Jim Harris
The code checks both rte_mp_request_sync() return code and that the number of messages in the reply equals 1. If rte_mp_request_sync() succeeds but there was more than one message, those messages would get leaked. Found via code review by Anatoly Burakov of patches that used the vhost code as a t