[dpdk-dev] [PATCH] vfio: don't silently drop VFIO support

2015-04-23 Thread Burakov, Anatoly
Hi Stephen, > What we ended up doing is a second patch to have a "compat_vfio.h" file to > allow building on older systems. I will send that as a follow on. I would argue it should be part of this series, as without them the patch breaks compilation on older kernels. > The problem is compounded

[dpdk-dev] [PATCH] vfio: don't silently drop VFIO support

2015-04-22 Thread Stephen Hemminger
On Wed, 22 Apr 2015 08:59:51 + "Burakov, Anatoly" wrote: > Hi Stephen, > > > > Hi Stephen, > > > > > > > The VFIO_PRESENT #define was a landmine and we hit it. > > > > The DPDK has a config system and it should be used rather than > > > > silently dropping a feature during build only to have

[dpdk-dev] [PATCH] vfio: don't silently drop VFIO support

2015-04-22 Thread Burakov, Anatoly
Hi Stephen, > > Hi Stephen, > > > > > The VFIO_PRESENT #define was a landmine and we hit it. > > > The DPDK has a config system and it should be used rather than > > > silently dropping a feature during build only to have it fail at run time. > > > > > > If VFIO is configured, and the kernel heade

[dpdk-dev] [PATCH] vfio: don't silently drop VFIO support

2015-04-21 Thread Stephen Hemminger
On Tue, 21 Apr 2015 09:34:27 + "Burakov, Anatoly" wrote: > Hi Stephen, > > > The VFIO_PRESENT #define was a landmine and we hit it. > > The DPDK has a config system and it should be used rather than silently > > dropping a feature during build only to have it fail at run time. > > > > If VF

[dpdk-dev] [PATCH] vfio: don't silently drop VFIO support

2015-04-21 Thread Burakov, Anatoly
Hi Stephen, > The VFIO_PRESENT #define was a landmine and we hit it. > The DPDK has a config system and it should be used rather than silently > dropping a feature during build only to have it fail at run time. > > If VFIO is configured, and the kernel headers are not present the build > should f

[dpdk-dev] [PATCH] vfio: don't silently drop VFIO support

2015-04-20 Thread Stephen Hemminger
The VFIO_PRESENT #define was a landmine and we hit it. The DPDK has a config system and it should be used rather than silently dropping a feature during build only to have it fail at run time. If VFIO is configured, and the kernel headers are not present the build should fail. Rather than leaving