Re: [dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Stephen Hemminger
On Fri, 08 Feb 2019 12:04:22 -0500 Aaron Conole wrote: > Pallantla Poornima writes: > > > sprintf function is not secure as it doesn't check the length of string. > > More secure function snprintf is used. > > > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > > Cc: sta...@dp

Re: [dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Aaron Conole
Pallantla Poornima writes: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf is used. > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > Cc: sta...@dpdk.org > > Signed-off-by: Pallantla Poornima > --- > test/test/comman

Re: [dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Stephen Hemminger
On Fri, 8 Feb 2019 13:27:37 + Pallantla Poornima wrote: > diff --git a/test/test/commands.c b/test/test/commands.c > index 94fbc310e..5aeb35498 100644 > --- a/test/test/commands.c > +++ b/test/test/commands.c > @@ -367,6 +367,8 @@ int commands_init(void) > struct test_command *t; >

Re: [dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Bruce Richardson
On Fri, Feb 08, 2019 at 01:27:37PM +, Pallantla Poornima wrote: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf is used. > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > Cc: sta...@dpdk.org > > Signed-off-by: Pall

[dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 727909c592 ("app/test: introduce dynamic commands list") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/commands.c | 7 ++- 1 file changed, 6 insertion