On Thu, Jul 2, 2020 at 10:47 PM Honnappa Nagarahalli
wrote:
> > Rework test code to reduce code complexity for the compiler and bring down
> > compilation time and memory consumption.
> >
> > Signed-off-by: Konstantin Ananyev
> Acked-by: Honnappa Nagarahalli
>
Updated commitlog with Konstantin
>
> Rework test code to reduce code complexity for the compiler and bring down
> compilation time and memory consumption.
>
> Signed-off-by: Konstantin Ananyev
Thomas has a nit [1]. Otherwise,
Acked-by: Honnappa Nagarahalli
[1] http://mails.dpdk.org/archives/dev/2020-May/166325.html
> ---
> > > > > > > > > > > > > Hi Konstantin,
> > > > > > > > > > > > > I like the way the tests are organized and it
> > > > > > > > > > > > > looks
> > > > good.
> > > > > > > > > > > > >
> > > > > > > > > > > > > I am just wondering about the way it is being tested
> > > > > > > > > > > > >
>
> > > > > > > > > > >
> > > > > > > > > > > > Hi Konstantin,
> > > > > > > > > > > > I like the way the tests are organized and it
> > > > > > > > > > > > looks
> > > good.
> > > > > > > > > > > >
> > > > > > > > > > > > I am just wondering about the way it is being tested
> > > > > >
> > > > > > > > > >
> > > > > > > > > > > Hi Konstantin,
> > > > > > > > > > > I like the way the tests are organized and it looks
> > good.
> > > > > > > > > > >
> > > > > > > > > > > I am just wondering about the way it is being tested here.
> > > > > > > > > > > The intent to write the test ca
> > > >
> > > >
> > > > > > > > >
> > > > > > > > > > Hi Konstantin,
> > > > > > > > > > I like the way the tests are organized and it looks
> good.
> > > > > > > > > >
> > > > > > > > > > I am just wondering about the way it is being tested here.
> > > > > > > > > > The intent to write the
> > >
> > >
> > > > > > > >
> > > > > > > > > Hi Konstantin,
> > > > > > > > > I like the way the tests are organized and it looks
> > > > > > > > > good.
> > > > > > > > >
> > > > > > > > > I am just wondering about the way it is being tested here.
> > > > > > > > > The intent to write the
> >
> >
> > > > > > >
> > > > > > > > Hi Konstantin,
> > > > > > > > I like the way the tests are organized and it looks
> > > > > > > > good.
> > > > > > > >
> > > > > > > > I am just wondering about the way it is being tested here.
> > > > > > > > The intent to write the test cases the
>
>
> > > > > >
> > > > > > > Hi Konstantin,
> > > > > > > I like the way the tests are organized and it looks good.
> > > > > > >
> > > > > > > I am just wondering about the way it is being tested here. The
> > > > > > > intent to write the test cases the way they are currently is
> > > > > >
> > > > >
> > > > > > Hi Konstantin,
> > > > > > I like the way the tests are organized and it looks good.
> > > > > >
> > > > > > I am just wondering about the way it is being tested here. The
> > > > > > intent to write the test cases the way they are currently is
> > > > > > to mimic how t
> > > >
> > > > > Hi Konstantin,
> > > > > I like the way the tests are organized and it looks good.
> > > > >
> > > > > I am just wondering about the way it is being tested here. The
> > > > > intent to write the test cases the way they are currently is to
> > > > > mimic how the APIs would
> > >
> > > > Hi Konstantin,
> > > > I like the way the tests are organized and it looks good.
> > > >
> > > > I am just wondering about the way it is being tested here. The
> > > > intent to write the test cases the way they are currently is to
> > > > mimic how the APIs would be used mo
> >
> > > Hi Konstantin,
> > > I like the way the tests are organized and it looks good.
> > >
> > > I am just wondering about the way it is being tested here. The intent
> > > to write the test cases the way they are currently is to mimic how the
> > > APIs would be used mostly. IMO, the APIs
30/04/2020 16:43, Ananyev, Konstantin:
>
> Hi Honnappa,
>
> > Hi Konstantin,
> > I like the way the tests are organized and it looks good.
> >
> > I am just wondering about the way it is being tested here. The intent to
> > write the test cases the way they are currently is to mimic how th
>
>
> Hi Honnappa,
>
> > Hi Konstantin,
> > I like the way the tests are organized and it looks good.
> >
> > I am just wondering about the way it is being tested here. The intent
> > to write the test cases the way they are currently is to mimic how the
> > APIs would be used mostly. IMO,
Hi Honnappa,
> Hi Konstantin,
> I like the way the tests are organized and it looks good.
>
> I am just wondering about the way it is being tested here. The intent to
> write the test cases the way they are currently is to mimic how the
> APIs would be used mostly. IMO, the APIs would b
Hi Konstantin,
I like the way the tests are organized and it looks good.
I am just wondering about the way it is being tested here. The intent to write
the test cases the way they are currently is to mimic how the APIs would be
used mostly. IMO, the APIs would be used with a constant val
Konstantin Ananyev writes:
> Rework test code to reduce code complexity for the compiler
> and bring down compilation time and memory consumption.
>
> Signed-off-by: Konstantin Ananyev
> ---
I'll wait for Honnappa's review, but this looks good to me. Consider
that I will ACK by the end of the
Hi Konstantin,
Thanks for the patch. I think we need to co-ordinate better on the
rte_ring related work to avoid duplicating the efforts. I also have been
working on a patch myself and it is undergoing internal review.
I will review this patch soon.
Thanks,
Honnappa
> -Original Mes
Rework test code to reduce code complexity for the compiler
and bring down compilation time and memory consumption.
Signed-off-by: Konstantin Ananyev
---
app/test/test_ring.c | 373 +--
1 file changed, 249 insertions(+), 124 deletions(-)
diff --git a/app/
20 matches
Mail list logo
