RE: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
[Fiona] Sorry for all the hassle. I've reviewed the related code and fix.
In my opinion the original fix was ok to resolve the compile issue, which
we missed due to using a different compiler version and also missed
spotti
-Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Friday, April 19, 2019 1:50 PM
> To: Jozwiak, TomaszX
> Cc: dev@dpdk.org; Richardson, Bruce ;
> david.march...@redhat.com; Trahe, Fiona ;
> ys...@mellanox.com; Cel, TomaszX
> Subject: Re: [dpdk-dev
Please stop top-posting, and read again below:
19/04/2019 13:36, Jozwiak, TomaszX:
> test_deflate_comp_decomp function is common for all test cases.
> The options for this function are inside struct interim_data_params,
> which is passed to test_deflate_comp_decomp function as a pointer.
>
> The
> To: Jozwiak, TomaszX
> Cc: dev@dpdk.org; Richardson, Bruce ;
> david.march...@redhat.com; Trahe, Fiona ;
> ys...@mellanox.com; Cel, TomaszX
> Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
>
> 19/04/2019 12:57, Jozwiak, TomaszX:
> > > Wha
19/04/2019 12:57, Jozwiak, TomaszX:
> > What is supposed to be "i"?
> > It is initialized at 0 and never touched.
> >
> It's touched inside test_deflate_comp_decomp function.
What do you mean?
It's a local variable and its address is referenced:
int_data.buf_idx = &i;
It looks really wrong
On Fri, Apr 19, 2019 at 11:57 AM Tomasz Jozwiak
wrote:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
>
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak
> ---
> app/test/test_compressdev.
Please check my comments below:
19/04/2019 11:57, Tomasz Jozwiak:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
It is seen with more compilers:
https://build.opensuse.org/project/show/home:bluca:dpdk
Please add the log of the error.
> Fixes: 355b02eedc65 ("test/
On Fri, Apr 19, 2019 at 11:57:07AM +0200, Tomasz Jozwiak wrote:
> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
>
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak
> ---
> app/test/test_com
Fixed the compilation error on gcc (GCC)
4.8.5 20150623 (Red Hat 4.8.5-28)
Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
Cc: sta...@dpdk.org
Signed-off-by: Tomasz Jozwiak
---
app/test/test_compressdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
9 matches
Mail list logo
