Re: [dpdk-dev] [PATCH] service: clean references to removed symbol

2021-04-08 Thread Thomas Monjalon
08/04/2021 16:04, David Marchand: > On Thu, Apr 8, 2021 at 3:08 PM Van Haaren, Harry > wrote: > > > > For rte_service.h doc changes I'm all fine. > > > > > > > > For ABI consistency, this removes a function from the DPDK_21 version > > > > map that > > > didn't exist in > > > > the shared object

Re: [dpdk-dev] [PATCH] service: clean references to removed symbol

2021-04-08 Thread David Marchand
On Thu, Apr 8, 2021 at 3:08 PM Van Haaren, Harry wrote: > > > For rte_service.h doc changes I'm all fine. > > > > > > For ABI consistency, this removes a function from the DPDK_21 version map > > > that > > didn't exist in > > > the shared object itself. I'm not sure if that's an ABI break or not

Re: [dpdk-dev] [PATCH] service: clean references to removed symbol

2021-04-08 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Thursday, April 8, 2021 1:58 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; sta...@dpdk.org; Ray Kinsella ; Neil Horman > ; Pavan Nikhilesh > Subject: Re: [PATCH] service: clean references to removed symbol > > On Thu, Apr 8, 2021 at 2

Re: [dpdk-dev] [PATCH] service: clean references to removed symbol

2021-04-08 Thread David Marchand
On Thu, Apr 8, 2021 at 2:54 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: David Marchand > > Sent: Wednesday, April 7, 2021 10:07 AM > > To: dev@dpdk.org > > Cc: sta...@dpdk.org; Van Haaren, Harry ; Ray > > Kinsella ; Neil Horman ; Pavan > > Nikhilesh > > Subject: [PATCH

Re: [dpdk-dev] [PATCH] service: clean references to removed symbol

2021-04-08 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Wednesday, April 7, 2021 10:07 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Van Haaren, Harry ; Ray > Kinsella ; Neil Horman ; Pavan > Nikhilesh > Subject: [PATCH] service: clean references to removed symbol > > rte_service_get_id() was

[dpdk-dev] [PATCH] service: clean references to removed symbol

2021-04-07 Thread David Marchand
rte_service_get_id() was removed in v17.11 but the API description still referenced it and a version node was still present in EAL map. Fixes: 8edc9aaaf217 ("service: use id in get by name function") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_eal/include/rte_service.h | 5