Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2020-06-25 Thread Thomas Monjalon
25/06/2020 10:38, Singh, Jasvinder: > From: Thomas Monjalon > > > > Is this old patch still relevant? > > The stats params have been converted into 64 bit values during library rework > last year. > Therefore, patch is not relevant anymore. OK, this patch is marked as rejected then. Thanks

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2020-06-25 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 24, 2020 11:51 PM > To: Dumitrescu, Cristian ; Alan Dewar > ; Singh, Jasvinder > Cc: Stephen Hemminger ; dev@dpdk.org; > Alan Dewar > Subject: Re: [dpdk-dev] [PATCH] sched: add 64-bit count

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2020-06-24 Thread Thomas Monjalon
Is this old patch still relevant? 25/07/2018 11:02, Alan Dewar: > Hi Stephen, > > Sorry about the delay in responding to your comment. > > Maybe I'm missing something but I don't consider 64-bit counter > rollover to be a problem. > The DPDK QoS stats are just 32-bits wide and are zeroed when r

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2018-07-25 Thread Alan Dewar
Hi Stephen, Sorry about the delay in responding to your comment. Maybe I'm missing something but I don't consider 64-bit counter rollover to be a problem. The DPDK QoS stats are just 32-bits wide and are zeroed when read. So if we read them frequently enough the 32-bit counters won't wrap. This

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2018-07-23 Thread Stephen Hemminger
On Wed, 18 Jul 2018 15:51:39 +0100 alangordonde...@gmail.com wrote: > From: Alan Dewar > > Add new APIs to retrieve counters in 64-bit wide fields. > > Signed-off-by: Alan Dewar Do you want to consider 64 bit counter roll over on 32 bit platform? The problem is that incrementing an 64 bit val

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2018-07-23 Thread Alan Robertson
Looks good to me. Alan. On Wed, Jul 18, 2018 at 3:51 PM, wrote: > From: Alan Dewar > > Add new APIs to retrieve counters in 64-bit wide fields. > > Signed-off-by: Alan Dewar > --- > lib/librte_sched/rte_sched.c | 72 > lib/librte_sched/rte_sched.h

[dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

2018-07-18 Thread alangordondewar
From: Alan Dewar Add new APIs to retrieve counters in 64-bit wide fields. Signed-off-by: Alan Dewar --- lib/librte_sched/rte_sched.c | 72 lib/librte_sched/rte_sched.h | 76 ++ lib/librte_sched/rte_sched_versi