Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

2020-04-28 Thread Thinh Tran
I looked at it, but I have a simpler patch below that can resolve the conflict, including after removing previous patches in mlx4/mlx5 Thanks, Thinh Tran diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h b/lib/librte_eal/ppc/include/rte_memcpy.h index 25311ba1d..abeede231 100644 --- a/lib

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

2020-04-28 Thread David Marchand
On Tue, Apr 28, 2020 at 5:02 PM Thinh Tran wrote: > > Agreed, this is not rte_trace issue. Moving to rte_common.h does not > work neither, because altivec.h is included after and redefine bool > This conflict happens on PPC64, I'll create a different patch. Please look at Ori patch. Thanks. http

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

2020-04-28 Thread Thinh Tran
Agreed, this is not rte_trace issue. Moving to rte_common.h does not work neither, because altivec.h is included after and redefine bool This conflict happens on PPC64, I'll create a different patch. Thanks, Thinh Tran On 4/28/2020 2:57 AM, Jerin Jacob wrote: On Tue, Apr 28, 2020 at 3:29 AM Th

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

2020-04-28 Thread David Marchand
On Tue, Apr 28, 2020 at 9:58 AM Jerin Jacob wrote: > > On Tue, Apr 28, 2020 at 3:29 AM Thinh Tran wrote: > > > > The AltiVec header file breaks boolean type: > > > > In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0, > > from ../lib/librte_mempool/rte_mempoo

Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

2020-04-28 Thread Jerin Jacob
On Tue, Apr 28, 2020 at 3:29 AM Thinh Tran wrote: > > The AltiVec header file breaks boolean type: > > In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0, > from ../lib/librte_mempool/rte_mempool.h:54, > from ../lib/librte_mbuf/rte_mbuf.h:38,

[dpdk-dev] [PATCH] rte_trace: fix build on PPC64

2020-04-27 Thread Thinh Tran
The AltiVec header file breaks boolean type: In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0, from ../lib/librte_mempool/rte_mempool.h:54, from ../lib/librte_mbuf/rte_mbuf.h:38, from ../lib/librte_net/rte_ether.h:23,