Re: [dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

2019-04-03 Thread Thomas Monjalon
22/03/2019 19:09, Maxime Coquelin: > On 3/21/19 8:59 PM, Stephen Hemminger wrote: > > The divisor is not modified here. Doesn't really matter for optimizaton > > since the function is inline already; but helps with expressing > > intent. > > > > Signed-off-by: Stephen Hemminger > > Reviewed-by:

Re: [dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

2019-04-02 Thread Thomas Monjalon
02/04/2019 17:26, Stephen Hemminger: > On Wed, 27 Mar 2019 12:14:44 +0100 > Thomas Monjalon wrote: > > > 21/03/2019 20:59, Stephen Hemminger: > > > The divisor is not modified here. Doesn't really matter for optimizaton > > > since the function is inline already; but helps with expressing > > > i

Re: [dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

2019-04-02 Thread Stephen Hemminger
On Wed, 27 Mar 2019 12:14:44 +0100 Thomas Monjalon wrote: > 21/03/2019 20:59, Stephen Hemminger: > > The divisor is not modified here. Doesn't really matter for optimizaton > > since the function is inline already; but helps with expressing > > intent. > > > > Signed-off-by: Stephen Hemminger >

Re: [dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

2019-03-27 Thread Thomas Monjalon
21/03/2019 20:59, Stephen Hemminger: > The divisor is not modified here. Doesn't really matter for optimizaton > since the function is inline already; but helps with expressing > intent. > > Signed-off-by: Stephen Hemminger > --- > static __rte_always_inline uint64_t > -rte_reciprocal_divide_u64

Re: [dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

2019-03-22 Thread Maxime Coquelin
On 3/21/19 8:59 PM, Stephen Hemminger wrote: The divisor is not modified here. Doesn't really matter for optimizaton since the function is inline already; but helps with expressing intent. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_reciprocal.h | 2 +- 1 file c

[dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

2019-03-21 Thread Stephen Hemminger
The divisor is not modified here. Doesn't really matter for optimizaton since the function is inline already; but helps with expressing intent. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_reciprocal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/