So in my patch it was changed to only one memory access.
发件人: Stephen Hemminger
发送时间: 2020年3月5日 1:37
收件人: tgw_team(腾讯网关团队)
抄送: Tencent TGW team; Thomas Monjalon; Ferruh Yigit; Andrew Rybchenko;
dev@dpdk.org
主题: Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe
On Wed, 4 Mar 2020 16:38:13 +
tgw_team(腾讯网关团队) wrote:
> Sorry, I`ll use a real name in patch v2.
>
> I don't think this is a TOCTOU question.
> The original code works fine when compiled with the -O3 option.
> At this point the compiler will optimize to one memory access.
> But when compiled
Sorry, I`ll use a real name in patch v2.
I don't think this is a TOCTOU question.
The original code works fine when compiled with the -O3 option.
At this point the compiler will optimize to one memory access.
But when compiled with -O0, there will be two memory accesses, which is wrong.
This chang
As a newcomer, I'm sorry for my mistakes. I will try to do better in the future.
>On 3/4/20 5:05 PM, Tencent TGW team wrote:
>> When compiling with -O0,
>> the compiler does not optimize two memory accesses into one.
>> Leads to accessing a null pointer when calling the RX callback.
>> The way to
On Wed, 4 Mar 2020 22:05:43 +0800
Tencent TGW team wrote:
> When compiling with -O0,
> the compiler does not optimize two memory accesses into one.
> Leads to accessing a null pointer when calling the RX callback.
> The way to access the TX callback is correct.
>
> Signed-off-by: Tencent TGW te
On 3/4/20 5:05 PM, Tencent TGW team wrote:
> When compiling with -O0,
> the compiler does not optimize two memory accesses into one.
> Leads to accessing a null pointer when calling the RX callback.
> The way to access the TX callback is correct.
It looks like the patch is not passed through check
When compiling with -O0,
the compiler does not optimize two memory accesses into one.
Leads to accessing a null pointer when calling the RX callback.
The way to access the TX callback is correct.
Signed-off-by: Tencent TGW team
---
lib/librte_ethdev/rte_ethdev.h | 6 ++
1 file changed, 2 ins
7 matches
Mail list logo
