Re: [dpdk-dev] [PATCH] ppp implemantation

2017-03-03 Thread Bruce Richardson
On Fri, Mar 03, 2017 at 09:39:26AM +, Bruce Richardson wrote: > Given that this patch is not about point-to-point protocol, i.e. the > best-known expansion of "PPP", I think you need to clarify the acronym > in the commit message, at minimum, if not also in the commit title. > > /Bruce > Nev

Re: [dpdk-dev] [PATCH] ppp implemantation

2017-03-03 Thread Bruce Richardson
Given that this patch is not about point-to-point protocol, i.e. the best-known expansion of "PPP", I think you need to clarify the acronym in the commit message, at minimum, if not also in the commit title. /Bruce On Fri, Mar 03, 2017 at 03:26:07PM +0800, Beilei Xing wrote: > Signed-off-by: Beil

[dpdk-dev] [PATCH] ppp implemantation

2017-03-02 Thread Beilei Xing
Signed-off-by: Beilei Xing --- app/test-pmd/cmdline.c | 57 app/test-pmd/config.c | 62 + app/test-pmd/testpmd.h | 3 + drivers/net/i40e/base/i40e_adminq_cmd.h | 33 +++ drivers/net/i40e/base/i40e_common.c |

[dpdk-dev] [PATCH] ppp implemantation

2017-03-02 Thread Beilei Xing
Signed-off-by: Beilei Xing --- app/test-pmd/cmdline.c | 57 app/test-pmd/config.c | 62 + app/test-pmd/testpmd.h | 3 + drivers/net/i40e/base/i40e_adminq_cmd.h | 32 + drivers/net/i40e/base/i40e_common.c | 236 +