Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-15 Thread Thomas Monjalon
07/04/2021 18:10, David Hunt: > Hi Anatoly, > > On 7/4/2021 4:56 PM, Anatoly Burakov wrote: > > Previous fix has addressed the incorrect handling of `base_frequency` > > file, but has added a use-after-free error due to the fact that all > > further code paths will lead to an `fclose()` call at th

Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-07 Thread Liang Ma
On Wed, Apr 07, 2021 at 05:53:48PM +0100, Burakov, Anatoly wrote: > On 07-Apr-21 5:31 PM, Burakov, Anatoly wrote: > > On 07-Apr-21 4:56 PM, Anatoly Burakov wrote: > > > Previous fix has addressed the incorrect handling of `base_frequency` > > > file, but has added a use-after-free error due to the

Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-07 Thread Burakov, Anatoly
On 07-Apr-21 5:31 PM, Burakov, Anatoly wrote: On 07-Apr-21 4:56 PM, Anatoly Burakov wrote: Previous fix has addressed the incorrect handling of `base_frequency` file, but has added a use-after-free error due to the fact that all further code paths will lead to an `fclose()` call at the end, so t

Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-07 Thread Burakov, Anatoly
On 07-Apr-21 4:56 PM, Anatoly Burakov wrote: Previous fix has addressed the incorrect handling of `base_frequency` file, but has added a use-after-free error due to the fact that all further code paths will lead to an `fclose()` call at the end, so the additional `fclose()` call right after proce

Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-07 Thread Liang Ma
Reviewed-by: Liang Ma On Wed, Apr 07, 2021 at 03:56:42PM +, Anatoly Burakov wrote: > Previous fix has addressed the incorrect handling of `base_frequency` > file, but has added a use-after-free error due to the fact that all > further code paths will lead to an `fclose()` call at the end, so

Re: [dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-07 Thread David Hunt
Hi Anatoly, On 7/4/2021 4:56 PM, Anatoly Burakov wrote: Previous fix has addressed the incorrect handling of `base_frequency` file, but has added a use-after-free error due to the fact that all further code paths will lead to an `fclose()` call at the end, so the additional `fclose()` call right

[dpdk-dev] [PATCH] power: fix use-after-free in pstate code

2021-04-07 Thread Anatoly Burakov
Previous fix has addressed the incorrect handling of `base_frequency` file, but has added a use-after-free error due to the fact that all further code paths will lead to an `fclose()` call at the end, so the additional `fclose()` call right after processing the file was unnecessary. Coverity issue