[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-27 Thread Thomas Monjalon
> > Commit 9fc37d1c071c is missing a conditional in the dependencies, > > causing builds to fail when KNI is not enabled: > > == Build lib/librte_port > > LD librte_port.so.3 > > /usr/bin/ld: cannot find -lrte_kni > > collect2: error: ld returned 1 exit status > > > > Fixes: 9fc3

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.com] > Sent: Wednesday, June 22, 2016 12:34 PM > To: dev at dpdk.org > Cc: Dumitrescu, Cristian ; > zhuangwj at gmail.com > Subject: [PATCH] port: fix build when KNI support is not enabled > > Commit 9fc37d1c071c is

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-23 Thread Olivier Matz
Hi Bruce, On 06/23/2016 10:53 AM, Bruce Richardson wrote: >>> If we want to specifically build this directory, why preventing us to do >>> so with CONFIG_RTE_LIBRTE_PORT? >> >> If we call foo_sub with CONFIG_FOO=n, it will generate a library and >> install headers in the build directory, however t

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-23 Thread Bruce Richardson
On Wed, Jun 22, 2016 at 05:32:37PM +0200, Olivier Matz wrote: > On 06/22/2016 02:20 PM, Thomas Monjalon wrote: > > 2016-06-22 13:57, Olivier Matz: > >> Hi Thomas, > >> > >> On 06/22/2016 01:49 PM, Thomas Monjalon wrote: > >>> 2016-06-22 14:34, Panu Matilainen: > --- a/lib/librte_port/Makefile

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-22 Thread Olivier Matz
On 06/22/2016 02:20 PM, Thomas Monjalon wrote: > 2016-06-22 13:57, Olivier Matz: >> Hi Thomas, >> >> On 06/22/2016 01:49 PM, Thomas Monjalon wrote: >>> 2016-06-22 14:34, Panu Matilainen: --- a/lib/librte_port/Makefile +++ b/lib/librte_port/Makefile @@ -82,6 +82,8 @@ DEPDIRS-$(CONFIG_

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-22 Thread Panu Matilainen
Commit 9fc37d1c071c is missing a conditional in the dependencies, causing builds to fail when KNI is not enabled: == Build lib/librte_port LD librte_port.so.3 /usr/bin/ld: cannot find -lrte_kni collect2: error: ld returned 1 exit status Fixes: 9fc37d1c071c ("port: support KNI")

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-22 Thread Thomas Monjalon
2016-06-22 13:57, Olivier Matz: > Hi Thomas, > > On 06/22/2016 01:49 PM, Thomas Monjalon wrote: > > 2016-06-22 14:34, Panu Matilainen: > >> --- a/lib/librte_port/Makefile > >> +++ b/lib/librte_port/Makefile > >> @@ -82,6 +82,8 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_mempool > >> DEPDIR

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-22 Thread Olivier Matz
Hi Thomas, On 06/22/2016 01:49 PM, Thomas Monjalon wrote: > 2016-06-22 14:34, Panu Matilainen: >> --- a/lib/librte_port/Makefile >> +++ b/lib/librte_port/Makefile >> @@ -82,6 +82,8 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_mempool >> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ether

[dpdk-dev] [PATCH] port: fix build when KNI support is not enabled

2016-06-22 Thread Thomas Monjalon
2016-06-22 14:34, Panu Matilainen: > --- a/lib/librte_port/Makefile > +++ b/lib/librte_port/Makefile > @@ -82,6 +82,8 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_mempool > DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ether > DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ip_frag > DEP