> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, March 23, 2021 7:56 PM
> To: P, Venkata Suresh Kumar ;
> Dumitrescu, Cristian
> Cc: dev@dpdk.org; Khangar, Churchill ; Jangra,
> Yogesh
> Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor
23/03/2021 19:56, Dumitrescu, Cristian:
> From: Thomas Monjalon
> > 23/03/2021 19:07, P, Venkata Suresh Kumar:
> > > Thanks a lot for reviewing the code and providing your comments.
> > >
> > > I have addressed below comments in V2 patch.
> >
> > OK thanks.
> >
> > What about the question about
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, March 23, 2021 6:39 PM
> To: P, Venkata Suresh Kumar ;
> Dumitrescu, Cristian
> Cc: dev@dpdk.org; Khangar, Churchill ; Jangra,
> Yogesh
> Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor
23/03/2021 19:07, P, Venkata Suresh Kumar:
> Thanks a lot for reviewing the code and providing your comments.
>
> I have addressed below comments in V2 patch.
OK thanks.
What about the question about rte_trace?
Opinions?
> From: Thomas Monjalon
> 19/03/2021 13:02, Venkata Suresh Kumar P:
>
On Fri, 19 Mar 2021 08:02:06 -0400
Venkata Suresh Kumar P wrote:
> +/*
> + * FD Reader
> + */
> +struct reader {
> + struct {
> + int fd;
> + uint32_t mtu;
> + uint32_t burst_size;
> + struct rte_mempool *mempool;
> + } params;
> +
> + s
On Fri, 19 Mar 2021 08:02:06 -0400
Venkata Suresh Kumar P wrote:
> +static void
> +__writer_flush(struct writer *p)
> +{
> + struct rte_mbuf *pkt;
> + void *pkt_data;
> + size_t n_bytes;
> + ssize_t ret;
> + uint32_t i;
> +
> + for (i = 0; i < p->n_pkts; i++) {
> +
On Fri, 19 Mar 2021 08:02:06 -0400
Venkata Suresh Kumar P wrote:
> +static void
> +reader_stats_read(void *port, struct rte_swx_port_in_stats *stats)
> +{
> + struct reader *p = port;
> +
> + memcpy(stats, &p->stats, sizeof(p->stats));
> +}
Why not use structure assignment (which is type
tian ;
Khangar, Churchill ; Jangra, Yogesh
Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port
19/03/2021 13:02, Venkata Suresh Kumar P:
> Add the file descriptor input/output port type for the SWX pipeline.
I think it deserves a bit more explanation about what is FD I
19/03/2021 13:02, Venkata Suresh Kumar P:
> Add the file descriptor input/output port type for the SWX pipeline.
I think it deserves a bit more explanation about what is FD I/O port.
> /*
> + * tap
> + */
> +#define TAP_DEV"/dev/net/tun"
Spaces are fr
Add the file descriptor input/output port type for the SWX pipeline.
Signed-off-by: Venkata Suresh Kumar P
Signed-off-by: Churchill Khangar
Acked-by: Cristian Dumitrescu
Depends-on: patch-87498 ("port: add ring SWX port")
---
doc/api/doxy-api-index.md | 1 +
examples/pipeline/cli.c
10 matches
Mail list logo
