Re: [dpdk-dev] [PATCH] pmdinfogen: fix resource leak of FILE object

2018-02-05 Thread Thomas Monjalon
02/02/2018 19:47, Neil Horman: > On Fri, Feb 02, 2018 at 03:51:12PM +, Bruce Richardson wrote: > > On Fri, Feb 02, 2018 at 03:47:43PM +, Bruce Richardson wrote: > > > On Fri, Feb 02, 2018 at 07:44:39AM -0500, Neil Horman wrote: > > > > On Fri, Feb 02, 2018 at 12:00:58PM +, Bruce Richard

Re: [dpdk-dev] [PATCH] pmdinfogen: fix resource leak of FILE object

2018-02-02 Thread Neil Horman
On Fri, Feb 02, 2018 at 03:51:12PM +, Bruce Richardson wrote: > On Fri, Feb 02, 2018 at 03:47:43PM +, Bruce Richardson wrote: > > On Fri, Feb 02, 2018 at 07:44:39AM -0500, Neil Horman wrote: > > > On Fri, Feb 02, 2018 at 12:00:58PM +, Bruce Richardson wrote: > > > > Coverity flags an is

Re: [dpdk-dev] [PATCH] pmdinfogen: fix resource leak of FILE object

2018-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2018 at 03:47:43PM +, Bruce Richardson wrote: > On Fri, Feb 02, 2018 at 07:44:39AM -0500, Neil Horman wrote: > > On Fri, Feb 02, 2018 at 12:00:58PM +, Bruce Richardson wrote: > > > Coverity flags an issue where the resources used by the FILE object for > > > the temporary in

Re: [dpdk-dev] [PATCH] pmdinfogen: fix resource leak of FILE object

2018-02-02 Thread Bruce Richardson
On Fri, Feb 02, 2018 at 07:44:39AM -0500, Neil Horman wrote: > On Fri, Feb 02, 2018 at 12:00:58PM +, Bruce Richardson wrote: > > Coverity flags an issue where the resources used by the FILE object for > > the temporary input file are leaked. This is a very minor issue, but is > > easily fixed,

Re: [dpdk-dev] [PATCH] pmdinfogen: fix resource leak of FILE object

2018-02-02 Thread Neil Horman
On Fri, Feb 02, 2018 at 12:00:58PM +, Bruce Richardson wrote: > Coverity flags an issue where the resources used by the FILE object for > the temporary input file are leaked. This is a very minor issue, but is > easily fixed, while also avoiding later problems where we try to close > an invalid

[dpdk-dev] [PATCH] pmdinfogen: fix resource leak of FILE object

2018-02-02 Thread Bruce Richardson
Coverity flags an issue where the resources used by the FILE object for the temporary input file are leaked. This is a very minor issue, but is easily fixed, while also avoiding later problems where we try to close an invalid file descriptor in the failure case. The fix is to use "dup()" to get a