Re: [dpdk-dev] [PATCH] pdump: fix uninit not freeing statistics memzone

2021-11-03 Thread Thomas Monjalon
26/10/2021 21:57, Stephen Hemminger: > On Tue, 26 Oct 2021 12:53:01 +0100 > Konstantin Ananyev wrote: > > > diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c > > index 71602685d5..a708935861 100644 > > --- a/lib/pdump/rte_pdump.c > > +++ b/lib/pdump/rte_pdump.c > > @@ -74,6 +74,7 @@ stat

Re: [dpdk-dev] [PATCH] pdump: fix uninit not freeing statistics memzone

2021-10-26 Thread Stephen Hemminger
On Tue, 26 Oct 2021 12:53:01 +0100 Konstantin Ananyev wrote: > diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c > index 71602685d5..a708935861 100644 > --- a/lib/pdump/rte_pdump.c > +++ b/lib/pdump/rte_pdump.c > @@ -74,6 +74,7 @@ static const char MZ_RTE_PDUMP_STATS[] = "rte_pdump_stats

Re: [dpdk-dev] [PATCH] pdump: fix uninit not freeing statistics memzone

2021-10-26 Thread Pattan, Reshma
> -Original Message- > From: Ananyev, Konstantin . > > Fixes: 10f726efe26c ("pdump: support pcapng and filtering") The changes looks ok. In the commit message we should also add CC: with author name and email id below the fixes line. > > Signed-off-by: Konstantin Ananyev Acked-by:

[dpdk-dev] [PATCH] pdump: fix uninit not freeing statistics memzone

2021-10-26 Thread Konstantin Ananyev
rte_pdump_init() always allocates new memzone for pdump_stats. Though rte_pdump_uninit() never frees it. So the following combination will always fail: rte_pdump_init(); rte_pdump_uninit(); rte_pdump_init(); The issue was caught by pdump_autotest UT. While first test run successful, any consecutive