Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-17 Thread Ferruh Yigit
On 6/14/2021 5:36 PM, Andrew Rybchenko wrote: > On 6/10/21 12:22 PM, Olivier Matz wrote: >> Hi Gregory, >> >> On Thu, Jun 10, 2021 at 04:10:25AM +, Gregory Etelson wrote: >>> Hello, >>> >>> There was no activity that patch for a long time. >>> The patch is marked as failed, but we verified fail

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-17 Thread Tyler Retzlaff
On Thu, May 27, 2021 at 06:28:58PM +0300, Gregory Etelson wrote: > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h > index 4b728969c1..684bb028b2 100644 > --- a/lib/net/rte_ip.h > +++ b/lib/net/rte_ip.h > @@ -38,7 +38,21 @@ extern "C" { > * IPv4 Header > */ > struct rte_ipv4_hdr { > - uin

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-14 Thread Andrew Rybchenko
On 6/10/21 12:22 PM, Olivier Matz wrote: Hi Gregory, On Thu, Jun 10, 2021 at 04:10:25AM +, Gregory Etelson wrote: Hello, There was no activity that patch for a long time. The patch is marked as failed, but we verified failed tests and concluded that the failures can be ignored. https://pa

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-10 Thread Olivier Matz
Hi Gregory, On Thu, Jun 10, 2021 at 04:10:25AM +, Gregory Etelson wrote: > Hello, > > There was no activity that patch for a long time. > The patch is marked as failed, but we verified failed tests and concluded > that the failures can be ignored. > https://patchwork.dpdk.org/project/dpdk/pat

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-09 Thread Gregory Etelson
Monday, May 31, 2021 14:10 > > To: Ananyev, Konstantin ; Morten > Brørup > > ; dev@dpdk.org > > Cc: Matan Azrad ; Ori Kam ; > Raslan > > Darawsheh ; Iremonger, Bernard > > ; Olivier Matz > > > Subject: RE: [dpdk-dev] [PATCH] net: int

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-02 Thread Gregory Etelson
> On Thu, 3 Jun 2021 08:58:42 +0800 > "Min Hu (Connor)" wrote: > > > Hi, Morten and all, > > I have a questions which has bothering me for a long time. > > What's the difference between API and ABI? > > Why does this patch does not breake ABI, but break API(maybe)? > > > >

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-02 Thread Stephen Hemminger
On Thu, 3 Jun 2021 08:58:42 +0800 "Min Hu (Connor)" wrote: > Hi, Morten and all, > I have a questions which has bothering me for a long time. > What's the difference between API and ABI? > Why does this patch does not breake ABI, but break API(maybe)? > > Hope for y

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-02 Thread Min Hu (Connor)
Hi, Morten and all, I have a questions which has bothering me for a long time. What's the difference between API and ABI? Why does this patch does not breake ABI, but break API(maybe)? Hope for your reply, thanks. 在 2021/5/27 23:56, Morten Brørup 写道: From

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-02 Thread Gregory Etelson
Darawsheh ; Iremonger, Bernard > ; Olivier Matz > Subject: RE: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields > > > > > > > > RTE IPv4 header definition combines the `version' and `ihl' > > > > > > > fields into a single str

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-31 Thread Gregory Etelson
> > > > > > RTE IPv4 header definition combines the `version' and `ihl' > > > > > > fields into a single structure member. > > > > > > This patch introduces dedicated structure members for both > > > > `version' > > > > > > and `ihl' IPv4 fields. Separated header fields definitions > > > > > > allo

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-31 Thread Ananyev, Konstantin
> > > > > RTE IPv4 header definition combines the `version' and `ihl' > > > > > fields into a single structure member. > > > > > This patch introduces dedicated structure members for both > > > `version' > > > > > and `ihl' IPv4 fields. Separated header fields definitions allow > > > > > to crea

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-28 Thread Gregory Etelson
> > > > RTE IPv4 header definition combines the `version' and `ihl' > > > > fields into a single structure member. > > > > This patch introduces dedicated structure members for both > > `version' > > > > and `ihl' IPv4 fields. Separated header fields definitions allow > > > > to create simplified c

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-28 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Friday, 28 May 2021 12.21 > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gregory > Etelson > > > Sent: Thursday, 27 May 2021 17.29 > > and version fields > > > > > > RTE IPv4 header definition combin

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-28 Thread Ananyev, Konstantin
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gregory Etelson > > Sent: Thursday, 27 May 2021 17.29 > and version fields > > > > RTE IPv4 header definition combines the `version' and `ihl' fields > > into a single structure member. > > This patch introduces dedicated structure membe

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-27 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gregory Etelson > Sent: Thursday, 27 May 2021 17.29 and version fields > > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `vers

[dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-05-27 Thread Gregory Etelson
RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplified code to match on the IHL value in a flow rul