Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Thomas Monjalon
10/07/2020 16:40, Olivier Matz: > > > > > > > On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote: > > > > > > > > Per RFC768: > > > > > > > > If the computed checksum is zero, it is transmitted as all > > > ones. > > > > > > > > An all zero transmitted checksum value means that the > > > t

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 04:40:59PM +0200, Olivier Matz wrote: > On Fri, Jul 10, 2020 at 03:56:11PM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > > Sent: Friday, July 10, 2020 3:41 PM > > > > > > On Fri, Jul 10, 2020 at 03:29:36PM +0200, Mor

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 03:56:11PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > Sent: Friday, July 10, 2020 3:41 PM > > > > On Fri, Jul 10, 2020 at 03:29:36PM +0200, Morten Brørup wrote: > > > > From: Olivier Matz [mailto:olivier.m...@6wind.

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Friday, July 10, 2020 3:41 PM > > On Fri, Jul 10, 2020 at 03:29:36PM +0200, Morten Brørup wrote: > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > Sent: Friday, July 10, 2020 3:16 PM > > > > > > On Fri, Jul 10

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 03:29:36PM +0200, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, July 10, 2020 3:16 PM > > > > On Fri, Jul 10, 2020 at 03:10:34PM +0200, Morten Brørup wrote: > > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > > Se

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, July 10, 2020 3:16 PM > > On Fri, Jul 10, 2020 at 03:10:34PM +0200, Morten Brørup wrote: > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > Sent: Friday, July 10, 2020 2:41 PM > > > > > > On Fri, Jul 10, 2020 at 02:55

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 03:10:34PM +0200, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, July 10, 2020 2:41 PM > > > > On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote: > > > Per RFC768: > > > If the computed checksum is zero, it is transmi

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, July 10, 2020 2:41 PM > > On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote: > > Per RFC768: > > If the computed checksum is zero, it is transmitted as all ones. > > An all zero transmitted checksum value means that the

Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-10 Thread Olivier Matz
On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote: > Per RFC768: > If the computed checksum is zero, it is transmitted as all ones. > An all zero transmitted checksum value means that the transmitter > generated no checksum. > > RFC793 for TCP has no such special treatment for the checks

[dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-09 Thread Hongzhi Guo
Per RFC768: If the computed checksum is zero, it is transmitted as all ones. An all zero transmitted checksum value means that the transmitter generated no checksum. RFC793 for TCP has no such special treatment for the checksum of zero. Fixes: 6006818cfb26 ("net: new checksum functions") Cc: sta.